Merge lp:~ralsina/ubuntuone-control-panel/add-add-add into lp:ubuntuone-control-panel

Proposed by Roberto Alsina on 2012-08-24
Status: Merged
Approved by: Roberto Alsina on 2012-08-25
Approved revision: 350
Merged at revision: 350
Proposed branch: lp:~ralsina/ubuntuone-control-panel/add-add-add
Merge into: lp:ubuntuone-control-panel
Diff against target: 20 lines (+3/-3)
1 file modified
ubuntuone/controlpanel/gui/qt/addfolder.py (+3/-3)
To merge this branch: bzr merge lp:~ralsina/ubuntuone-control-panel/add-add-add
Reviewer Review Type Date Requested Status
Mike McCracken (community) 2012-08-24 Approve on 2012-08-24
Review via email: mp+121282@code.launchpad.net

Commit Message

- Switched to non-native dialog on darwin (LP:1040905).

Description of the Change

To test IRL:

* Start on mac
* Click "add a folder from this computer"
* see ugly dialog
* wait a minute
* ugly dialog still there? then it's fixed.

To post a comment you must log in.
Mike McCracken (mikemc) wrote :

Worked for me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/gui/qt/addfolder.py'
2--- ubuntuone/controlpanel/gui/qt/addfolder.py 2012-03-19 20:55:52 +0000
3+++ ubuntuone/controlpanel/gui/qt/addfolder.py 2012-08-24 20:44:20 +0000
4@@ -33,13 +33,13 @@
5 logger = setup_logging('qt.addfolder')
6
7 CLOSE = QtGui.QMessageBox.Close
8-# NOTE: this is temporary because of a Qt bug that will be fixed
9-# on Qt 4.9. You cannot, in general, use sys.platform in these
10+# NOTE: this is temporary because of Qt bugs.
11+# You cannot, in general, use sys.platform in these
12 # modules. Do not do this. Please. This is an exception, one
13 # time only, pinky-swear, cross my heart and hope to die if
14 # I lie.
15 FILE_CHOOSER_OPTIONS = QtGui.QFileDialog.ShowDirsOnly
16-if sys.platform == 'win32':
17+if sys.platform in ('win32', 'darwin'):
18 FILE_CHOOSER_OPTIONS |= QtGui.QFileDialog.DontUseNativeDialog
19 # Yes, that is true. If you do that again, you will be hunted
20 # down and taught a lesson. You will be sorry.

Subscribers

People subscribed via source and target branches