Merge lp:~ralsina/ubuntu-sso-client/pretty-little-liar into lp:ubuntu-sso-client
Proposed by
Roberto Alsina
Status: | Merged |
---|---|
Approved by: | Roberto Alsina |
Approved revision: | 967 |
Merged at revision: | 966 |
Proposed branch: | lp:~ralsina/ubuntu-sso-client/pretty-little-liar |
Merge into: | lp:ubuntu-sso-client |
Diff against target: |
53 lines (+3/-7) 4 files modified
ubuntu_sso/qt/current_user_sign_in_page.py (+1/-3) ubuntu_sso/qt/setup_account_page.py (+0/-1) ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+1/-1) ubuntu_sso/qt/tests/test_setup_account.py (+1/-2) |
To merge this branch: | bzr merge lp:~ralsina/ubuntu-sso-client/pretty-little-liar |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
dobey (community) | Approve | ||
Review via email: mp+109364@code.launchpad.net |
Commit message
- Remove back buttons in signin/signup pages (Fixes LP:1009107).
Description of the change
Remove the "Back" button from the two pages that are supposed to be "first".
To test:
1) Ensure you have network conenctivity
2) Remove your device
3) PYTHONPATH=. bin/ubuntu-
4) PYTHONPATH=. bin/ubuntu-
In 3) and 4) you should see the signup/signin pages without a "Back" button.
No tests because Qt doesn't provide a way to know the button layout of a page after it's set, AFAICS.
To post a comment you must log in.
Tested IRL, works as expected.