Merge lp:~ralsina/ubuntu-sso-client/no-more-stderr into lp:ubuntu-sso-client

[Roberto Alsina]

Make SSO not print to stderr.

Make SSO not print to stderr.

Unmerged revisions

764. By Roberto Alsina on 2011-08-23

Avoid using stderr

=== modified file 'bin/windows-ubuntu-sso-login'
--- bin/windows-ubuntu-sso-login	2011-07-22 22:00:45 +0000
+++ bin/windows-ubuntu-sso-login	2011-09-01 20:16:23 +0000
@@ -22,6 +22,25 @@
 # pylint: disable=C0103, E1101, F0401
 import sys
 
+
+# This has to be done as early as possible
+from ubuntu_sso.logger import setup_logging
+
+logger = setup_logging("windows-ubuntu-sso-login")
+
+
+# See python bug  http://bugs.python.org/issue11705
+def create_closure(logger):
+    def handleException(excType, excValue, traceback):
+            logger.error("Uncaught exception",
+                exc_info=(excType, excValue, traceback))
+    return handleException
+sys.excepthook = create_closure(logger)
+# On windows, we don't want to log to stderr when DEBUG is set
+# Or else, binaries will break when the user has it set.
+sys.stderr = sys.stdout
+
+
 from PyQt4 import QtGui
 # need to create the QApplication before installing the reactor
 app = QtGui.QApplication(sys.argv)
@@ -33,7 +52,6 @@
 from twisted.internet.task import LoopingCall
 from twisted.python import log
 
-from ubuntu_sso.logger import setup_logging
 from ubuntu_sso.main.windows import (
     CredentialsManagement,
     LOCALHOST,
@@ -45,13 +63,10 @@
 from ubuntu_sso.utils import tcpactivation
 
 
-logger = setup_logging("windows-ubuntu-sso-login")
-
-
 def add_timeout(interval, callback, *args, **kwargs):
     """Add a timeout callback as a task."""
     time_out_task = LoopingCall(callback, *args, **kwargs)
-    time_out_task.start(interval/1000, now=False)
+    time_out_task.start(interval / 1000, now=False)
 
 
 @defer.inlineCallbacks