Merge lp:~ralsina/ubuntu-push/check-hooks-path into lp:ubuntu-push/automatic

Proposed by Roberto Alsina
Status: Merged
Approved by: Roberto Alsina
Approved revision: 391
Merged at revision: 390
Proposed branch: lp:~ralsina/ubuntu-push/check-hooks-path
Merge into: lp:ubuntu-push/automatic
Diff against target: 12 lines (+2/-0)
1 file modified
scripts/click-hook (+2/-0)
To merge this branch: bzr merge lp:~ralsina/ubuntu-push/check-hooks-path
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+254926@code.launchpad.net

Commit message

report failure if hooks_path doesn't exist

Description of the change

report failure if hooks_path doesn't exist

To post a comment you must log in.
391. By Roberto Alsina

typo

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/click-hook'
2--- scripts/click-hook 2014-10-15 11:56:43 +0000
3+++ scripts/click-hook 2015-04-01 14:46:34 +0000
4@@ -53,6 +53,8 @@
5
6 def collect_helpers(helpers_data_path, helpers_data_path_tmp, hooks_path):
7 helpers_data = {}
8+ if not os.path.isdir(hooks_path):
9+ return True
10 for hook_fname in os.listdir(hooks_path):
11 if not hook_fname.endswith(hook_ext):
12 continue

Subscribers

People subscribed via source and target branches