Merge lp:~ralsina/ubuntu-push-qml/fix-watcher-leak into lp:ubuntu-push-qml

Proposed by Roberto Alsina on 2015-02-24
Status: Merged
Approved by: MichaƂ Karnicki on 2015-02-24
Approved revision: 17
Merged at revision: 18
Proposed branch: lp:~ralsina/ubuntu-push-qml/fix-watcher-leak
Merge into: lp:ubuntu-push-qml
Diff against target: 19 lines (+2/-0)
1 file modified
src/Ubuntu/PushNotifications/pushclient.cpp (+2/-0)
To merge this branch: bzr merge lp:~ralsina/ubuntu-push-qml/fix-watcher-leak
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve on 2015-02-24
Review via email: mp+250780@code.launchpad.net

Commit message

Don't leak watchers.

Description of the change

Don't leak watchers.

To post a comment you must log in.
Roberto Alsina (ralsina) wrote :

+1 from karni

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/PushNotifications/pushclient.cpp'
2--- src/Ubuntu/PushNotifications/pushclient.cpp 2015-01-19 18:42:19 +0000
3+++ src/Ubuntu/PushNotifications/pushclient.cpp 2015-02-24 15:37:32 +0000
4@@ -77,6 +77,7 @@
5 QTimer::singleShot(200, this, SLOT(getNotifications()));
6 emit tokenChanged(this->token);
7 }
8+ watcher->deleteLater();
9 }
10
11 QString PushClient::getAppId() {
12@@ -117,6 +118,7 @@
13 else {
14 emit notificationsChanged(reply.value());
15 }
16+ watcher->deleteLater();
17 }
18
19 QStringList PushClient::getPersistent() {

Subscribers

People subscribed via source and target branches