Merge lp:~ralsina/ubuntu-push-qml/fix-1403866 into lp:ubuntu-push-qml

Proposed by Roberto Alsina on 2015-01-19
Status: Merged
Approved by: Roberto Alsina on 2015-01-19
Approved revision: 17
Merged at revision: 16
Proposed branch: lp:~ralsina/ubuntu-push-qml/fix-1403866
Merge into: lp:ubuntu-push-qml
Diff against target: 12 lines (+1/-1)
1 file modified
src/Ubuntu/PushNotifications/pushclient.cpp (+1/-1)
To merge this branch: bzr merge lp:~ralsina/ubuntu-push-qml/fix-1403866
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve on 2015-01-19
John Lenton 2015-01-19 Approve on 2015-01-19
Review via email: mp+246939@code.launchpad.net

Commit message

Fix a typo that prevented setting the icon badge counter value from QML

Description of the change

Fix a typo that prevented setting the icon badge counter value from QML

To post a comment you must log in.
John Lenton (chipaca) wrote :

yeah, thanks.

review: Approve
17. By Roberto Alsina on 2015-01-19

link bug

Michał Karnicki (karni) wrote :

Thank you :)

review: Approve
18. By Roberto Alsina on 2015-01-19

link bug

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/PushNotifications/pushclient.cpp'
2--- src/Ubuntu/PushNotifications/pushclient.cpp 2014-11-21 19:16:22 +0000
3+++ src/Ubuntu/PushNotifications/pushclient.cpp 2015-01-19 18:53:37 +0000
4@@ -165,7 +165,7 @@
5 bool visible = count != 0;
6 counter = count;
7 path += "/" + pkgname;
8- QDBusMessage message = QDBusMessage::createMethodCall(POSTAL_SERVICE, path, POSTAL_IFACE, "setCounter");
9+ QDBusMessage message = QDBusMessage::createMethodCall(POSTAL_SERVICE, path, POSTAL_IFACE, "SetCounter");
10 message << this->appId << count << visible;
11 QDBusPendingCall pcall = bus.asyncCall(message);
12 QDBusPendingCallWatcher *watcher = new QDBusPendingCallWatcher(pcall, this);

Subscribers

People subscribed via source and target branches