Merge lp:~rakete/ecryptfs/find-fix into lp:~ecryptfs/ecryptfs/oldtrunk2

Proposed by Andreas Raster
Status: Merged
Merged at revision: 658
Proposed branch: lp:~rakete/ecryptfs/find-fix
Merge into: lp:~ecryptfs/ecryptfs/oldtrunk2
Diff against target: 12 lines (+1/-2)
1 file modified
src/desktop/ecryptfs-find (+1/-2)
To merge this branch: bzr merge lp:~rakete/ecryptfs/find-fix
Reviewer Review Type Date Requested Status
Dustin Kirkland  Pending
Review via email: mp+93839@code.launchpad.net

Description of the change

Just a tiny fix to the ecryptfs-find script. The $mounts var was quoted once to often, making the script fail if there are multiple ecryptfs mounts. I am assuming that /proc/mounts will never contain any spaces (they should always be escaped as \040), so if that assumption is wrong the script will fail when there is a space in a mount path.

I'd probably leave out the detection and automatic searching of mounts altoghether, just letting the user specify a directory with a second parameter or defaulting to .

To post a comment you must log in.
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Committed revision 658.

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/desktop/ecryptfs-find'
2--- src/desktop/ecryptfs-find 2011-07-19 19:32:36 +0000
3+++ src/desktop/ecryptfs-find 2012-02-20 13:55:41 +0000
4@@ -54,7 +54,6 @@
5 done < /proc/mounts
6
7 # Do the search
8-mounts=${mounts## }
9-for m in "$mounts"; do
10+for m in $mounts; do
11 find "$m/" -inum "$inum"
12 done

Subscribers

People subscribed via source and target branches