Merge lp:~raj-abhilash1/mailman/bugfix into lp:mailman

Proposed by Abhilash Raj on 2015-04-16
Status: Merged
Merged at revision: 7334
Proposed branch: lp:~raj-abhilash1/mailman/bugfix
Merge into: lp:mailman
Diff against target: 23 lines (+9/-0)
1 file modified
src/mailman/rest/tests/test_listconf.py (+9/-0)
To merge this branch: bzr merge lp:~raj-abhilash1/mailman/bugfix
Reviewer Review Type Date Requested Status
Mailman Coders 2015-04-16 Pending
Review via email: mp+256569@code.launchpad.net

Description of the change

Add test case for the falcon bug.

To post a comment you must log in.
lp:~raj-abhilash1/mailman/bugfix updated on 2015-04-18
7324. By Barry Warsaw on 2015-04-17

Plumb subscription request handling through the REST API.

7325. By Barry Warsaw on 2015-04-17

Fix MANIFEST.in to include all the necessary test data files.

7326. By Barry Warsaw on 2015-04-17

Documentation updates.

7327. By Barry Warsaw on 2015-04-17

VERSION.

7328. By Barry Warsaw on 2015-04-17

Remove todo from release branch.

7329. By Barry Warsaw on 2015-04-17

maxking's nickname

7330. By Barry Warsaw on 2015-04-18

Fix spellings.

7331. By Barry Warsaw on 2015-04-18

Date in NEWS.

Barry Warsaw (barry) wrote :

I'd like to merge this into trunk and create a release blocking bug for it. Then when Falcon releases 0.3 in the next day or two, we can verify that it fixes this problem and block the MM3 release.

Can you resolve the conflict?

lp:~raj-abhilash1/mailman/bugfix updated on 2015-04-19
7332. By Barry Warsaw on 2015-04-19

Set up for 3.0.0 final.

Abhilash Raj (raj-abhilash1) wrote :

I will do that asap!

lp:~raj-abhilash1/mailman/bugfix updated on 2015-04-21
7333. By Barry Warsaw on 2015-04-20

Typos; given by sumanah.

7334. By Barry Warsaw on 2015-04-21

raj-abhilash1's branch to ensure we block release on Falcon 0.3. I moved and
renamed his test.

Also, backfill a relevant Launchpad bug number.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/mailman/rest/tests/test_listconf.py'
2--- src/mailman/rest/tests/test_listconf.py 2015-04-15 18:36:28 +0000
3+++ src/mailman/rest/tests/test_listconf.py 2015-04-20 09:49:10 +0000
4@@ -92,6 +92,7 @@
5 self.assertEqual(set(IAcceptableAliasSet(self._mlist).aliases),
6 set(aliases))
7
8+
9 def test_patch_subscription_policy(self):
10 # The new subscription_policy value can be patched.
11 #
12@@ -108,3 +109,11 @@
13 # And now we verify that it has the requested setting.
14 self.assertEqual(self._mlist.subscription_policy,
15 SubscriptionPolicy.confirm_then_moderate)
16+
17+ @unittest.expectedFailure
18+ def test_bad_description_update(self):
19+ resource, response = call_api(
20+ 'http://localhost:9001/3.0/lists/test@example.com/config',
21+ dict(description='A description with , to check stuff'), 'PATCH')
22+ self.assertEqual(self._mlist.description,
23+ 'A description with , to check stuff')