Merge ~rahdjoudj/discourse-charm/+git/discourse-charm:discourse-charm into discourse-charm:master

Proposed by Reda Ahdjoudj
Status: Merged
Approved by: Haw Loeung
Approved revision: aee255aed1276b55e22e187eb071d29ec8d549ba
Merged at revision: 70f7f14b81528c205e773dcf10ccf33cc7718862
Proposed branch: ~rahdjoudj/discourse-charm/+git/discourse-charm:discourse-charm
Merge into: discourse-charm:master
Diff against target: 92 lines (+12/-11)
4 files modified
Makefile (+7/-8)
config.yaml (+1/-1)
layer.yaml (+3/-2)
wheelhouse.txt (+1/-0)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Discourse Charm Maintainers Pending
Review via email: mp+376383@code.launchpad.net

Commit message

Bug Fix(1855216): adding wheelhouse - update ruby default version - add brotli compression package to layer

Description of the change

adding psutil to wheelhouse so it's present in venv, since system package are not used.

Update default ruby version to be compatible with current discourse.

Add Brotli compression library to layer.yaml packages list as it's needed by discourse.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

Per inline comments, a few points to justify or tweak before landing.

review: Needs Information
Revision history for this message
Reda Ahdjoudj (rahdjoudj) wrote :

> Per inline comments, a few points to justify or tweak before landing.

Made the tweaks. Left the git add as I'm not sure of why it's in there.

Revision history for this message
Stuart Bishop (stub) wrote :

Yup

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change cannot be self approved, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change must be approved by a member of one of the following teams:
 - discourse-charmers
Setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 70f7f14b81528c205e773dcf10ccf33cc7718862

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index b612804..9a67e0a 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -26,7 +26,7 @@ LAYER_BRANCH := master
6 DEVEL_BRANCH := test-built
7 STABLE_BRANCH := built
8
9-BUILD_DIR := $(JUJU_REPOSITORY)/builds/$(CHARM_NAME)
10+BUILD_DIR := $(CHARM_DIR)/builds
11 CHARM_STORE_URL := $(CHARM_NAME)
12
13 SHELL := /bin/bash
14@@ -47,25 +47,24 @@ $(BUILD_DIR):
15 # from the working tree including all untracked and uncommitted
16 # updates.
17 .PHONY: build
18-build: | $(BUILD_DIR)
19- charm build -f -o $(JUJU_REPOSITORY) -n $(CHARM_NAME)
20+build: charm build -f -o $(BUILD_DIR)
21
22
23-# Generate a fresh development build and commit it to $(TEST_BRANCH).
24+# Generate a fresh development build and commit it to $(DEVEL_BRANCH).
25 # Only builds work committed to $(LAYER_BRANCH).
26 .PHONY: dev-build
27-build-dev: | $(BUILD_DIR)
28+build-dev:
29 -cd $(BUILD_DIR) && git merge --abort
30 cd $(BUILD_DIR) \
31- && git reset --hard $(TEST_BRANCH) \
32+ && git reset --hard $(DEVEL_BRANCH) \
33 && git clean -fxd \
34 && git merge --log --no-commit -s ours \
35 -m "charm-build of $(LAYER_BRANCH)" $(LAYER_BRANCH)
36 rm -rf .tmp-repo
37 git clone -b $(LAYER_BRANCH) . .tmp-repo
38- charm build -f -o $(JUJU_REPOSITORY) -n $(CHARM_NAME) .tmp-repo
39+ charm build -f -o $(BUILD_DIR) .tmp-repo
40 rm -rf .tmp-repo
41- cd $(BUILD_DIR) && git add .
42+ cd $(BUILD_DIR) && git add .
43 -cd $(BUILD_DIR) && git commit --no-edit
44
45
46diff --git a/config.yaml b/config.yaml
47index b3366a8..e3c9261 100644
48--- a/config.yaml
49+++ b/config.yaml
50@@ -21,7 +21,7 @@ options:
51 description: "Default mirror to pull Ruby from, choose one closest to your datacenter."
52 ruby-version:
53 type: string
54- default: '2.4.4'
55+ default: '2.6.5'
56 description: "Default Ruby version to install. Choose a version sufficiently new for Discourse."
57 admin-users:
58 type: string
59diff --git a/layer.yaml b/layer.yaml
60index c3d5c9a..98ca04d 100644
61--- a/layer.yaml
62+++ b/layer.yaml
63@@ -1,4 +1,4 @@
64-includes:
65+includes:
66 - 'layer:ruby'
67 - 'layer:git-deploy'
68 - 'interface:pgsql'
69@@ -16,7 +16,7 @@ options:
70 - gifsicle
71 - libpq-dev
72 - redis-server
73- - python3-psutil
74+ # - python3-psutil
75 - postfix
76 - postgresql-client-common
77 - postgresql-client
78@@ -26,6 +26,7 @@ options:
79 # Ubuntu) or else an as yet nonexistent version of 3.x or later
80 # that supports ES6 or at least "const" out of the box.
81 - node-uglify
82+ - brotli
83 git-deploy:
84 target: /srv/discourse
85 repo: 'https://git.launchpad.net/discourse-charm'
86diff --git a/wheelhouse.txt b/wheelhouse.txt
87new file mode 100644
88index 0000000..686138b
89--- /dev/null
90+++ b/wheelhouse.txt
91@@ -0,0 +1 @@
92+psutil>=5.4.2,<6.0.0

Subscribers

People subscribed via source and target branches