Merge lp:~raharper/curtin/trunk.multipath-skip-update-grub into lp:~curtin-dev/curtin/trunk

Proposed by Ryan Harper on 2017-01-13
Status: Merged
Merged at revision: 438
Proposed branch: lp:~raharper/curtin/trunk.multipath-skip-update-grub
Merge into: lp:~curtin-dev/curtin/trunk
Diff against target: 14 lines (+0/-5)
1 file modified
curtin/commands/curthooks.py (+0/-5)
To merge this branch: bzr merge lp:~raharper/curtin/trunk.multipath-skip-update-grub
Reviewer Review Type Date Requested Status
Scott Moser 2017-01-13 Approve on 2017-01-19
Server Team CI bot continuous-integration Approve on 2017-01-14
Review via email: mp+314738@code.launchpad.net

Commit message

multipath: don't run update-grub; setup_grub will handle this better.

During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.

Dropping the direct call to update-grub and deferring to curtin's
setup_grub method (which disables os-prober) works around the
issue. Separate bug filed against os-prober.

LP: #1656369

Description of the change

multipath: don't run update-grub; setup_grub will handle this better.

During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.

Dropping the direct call to update-grub and deferring to curtin's
setup_grub method (which disables os-prober) works around the
issue. Separate bug filed against os-prober.

LP: #1656369

To post a comment you must log in.
Scott Moser (smoser) wrote :

all fine, but uplease mention the os prober bug in the comment, rather than just that you filed one (so we can look and find it later).

Scott Moser (smoser) wrote :

approve with that one change.

review: Approve
438. By Ryan Harper on 2017-01-13

multipath: don't run update-grub; setup_grub will handle this better.

During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.

Dropping the direct call to update-grub and deferring to curtin's
setup_grub method (which disables os-prober) works around the
issue. Separate bug filed against os-prober.

LP: #1656369

Scott Moser (smoser) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'curtin/commands/curthooks.py'
2--- curtin/commands/curthooks.py 2016-11-30 23:54:16 +0000
3+++ curtin/commands/curthooks.py 2017-01-13 19:19:35 +0000
4@@ -560,11 +560,6 @@
5 ''])
6 util.write_file(grub_cfg, content=msg)
7
8- # FIXME: this assumes grub. need more generic way to update root=
9- util.ensure_dir(os.path.sep.join([target, os.path.dirname(grub_dev)]))
10- with util.ChrootableTarget(target) as in_chroot:
11- in_chroot.subp(['update-grub'])
12-
13 else:
14 LOG.warn("Not sure how this will boot")
15

Subscribers

People subscribed via source and target branches