Merge lp:~raharper/curtin/trunk.multipath-skip-update-grub into lp:~curtin-dev/curtin/trunk

[Ryan Harper]

multipath: don't run update-grub; setup_grub will handle this better.

During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.

Dropping the direct call to update-grub and deferring to curtin's
setup_grub method (which disables os-prober) works around the
issue. Separate bug filed against os-prober.

LP: #1656369

multipath: don't run update-grub; setup_grub will handle this better.

During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.

Dropping the direct call to update-grub and deferring to curtin's
setup_grub method (which disables os-prober) works around the
issue. Separate bug filed against os-prober.

LP: #1656369

[Scott Moser (smoser)]

all fine, but uplease mention the os prober bug in the comment, rather than just that you filed one (so we can look and find it later).

[Scott Moser (smoser)]

approve with that one change.

review: Approve

[lp:~raharper/curtin/trunk.multipath-skip-update-grub]

438. By Ryan Harper on 2017-01-13

multipath: don't run update-grub; setup_grub will handle this better.

During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.

Dropping the direct call to update-grub and deferring to curtin's
setup_grub method (which disables os-prober) works around the
issue. Separate bug filed against os-prober.

LP: #1656369

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:438
https://jenkins.ubuntu.com/server/job/curtin-ci/280/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=vm-amd64/280
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=vm-i386/280
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=vm-ppc64el/280
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=vm-s390x/280

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/280/rebuild

review: Approve (continuous-integration)

[Ryan Harper (raharper)]

PASSES (test_multipath only): https://jenkins.ubuntu.com/server/job/curtin-vmtest-devel/22/console

[Scott Moser (smoser)]

review: Approve

=== modified file 'curtin/commands/curthooks.py'
--- curtin/commands/curthooks.py	2016-11-30 23:54:16 +0000
+++ curtin/commands/curthooks.py	2017-01-13 19:19:35 +0000
@@ -560,11 +560,6 @@
             ''])
         util.write_file(grub_cfg, content=msg)
 
-        # FIXME: this assumes grub. need more generic way to update root=
-        util.ensure_dir(os.path.sep.join([target, os.path.dirname(grub_dev)]))
-        with util.ChrootableTarget(target) as in_chroot:
-            in_chroot.subp(['update-grub'])
-
     else:
         LOG.warn("Not sure how this will boot")