Merge lp:~raharper/curtin/trunk.lp1662346 into lp:~smoser/curtin/trunk.lp1662346

[Ryan Harper]

Add unittest for s390-tools install for zipl

[lp:~raharper/curtin/trunk.lp1662346]

454. By Ryan Harper on 2017-02-08

Fix mocking of class via patch.object

=== modified file 'tests/unittests/test_curthooks.py'
--- tests/unittests/test_curthooks.py	2016-11-30 23:54:16 +0000
+++ tests/unittests/test_curthooks.py	2017-02-08 21:18:26 +0000
@@ -6,6 +6,7 @@
 
 from curtin.commands import curthooks
 from curtin import util
+from curtin.reporter import events
 
 
 class CurthooksBase(TestCase):
@@ -131,4 +132,47 @@
         ]
         self.mock_subp.assert_has_calls(subp_calls)
 
+
+class TestInstallMissingPkgs(CurthooksBase):
+    def setUp(self):
+        super(TestInstallMissingPkgs, self).setUp()
+        self.add_patch('platform.machine', 'mock_machine')
+        self.add_patch('curtin.util.get_installed_packages',
+                       'mock_get_installed_packages')
+        self.add_patch('curtin.util.load_command_environment',
+                       'mock_load_cmd_evn')
+        self.add_patch('curtin.util.which', 'mock_which')
+        self.add_patch('curtin.util.install_packages', 'mock_install_packages')
+
+    @patch.object(events, 'ReportEventStack')
+    def test_install_packages_s390x(self, mock_events):
+
+        self.mock_machine.return_value = "s390x"
+        self.mock_which.return_value = False
+        target = "not-a-real-target"
+        cfg = {}
+        curthooks.install_missing_packages(cfg, target=target)
+        self.mock_install_packages.assert_called_with(['s390-tools'],
+                                                      target=target)
+
+    @patch.object(events, 'ReportEventStack')
+    def test_install_packages_s390x_has_zipl(self, mock_events):
+
+        self.mock_machine.return_value = "s390x"
+        self.mock_which.return_value = True
+        target = "not-a-real-target"
+        cfg = {}
+        curthooks.install_missing_packages(cfg, target=target)
+        self.assertEqual([], self.mock_install_packages.call_args_list)
+
+    @patch.object(events, 'ReportEventStack')
+    def test_install_packages_x86_64_no_zipl(self, mock_events):
+
+        self.mock_machine.return_value = "x86_64"
+        target = "not-a-real-target"
+        cfg = {}
+        curthooks.install_missing_packages(cfg, target=target)
+        self.assertEqual([], self.mock_install_packages.call_args_list)
+
+
 # vi: ts=4 expandtab syntax=python