Merge lp:~raharper/curtin/trunk.fix-vmtest-install-ok-check into lp:~curtin-dev/curtin/trunk
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Approved by: | Scott Moser |
Approved revision: | 307 |
Merged at revision: | 312 |
Proposed branch: | lp:~raharper/curtin/trunk.fix-vmtest-install-ok-check |
Merge into: | lp:~curtin-dev/curtin/trunk |
Diff against target: |
57 lines (+33/-6) 1 file modified
tests/vmtests/__init__.py (+33/-6) |
To merge this branch: | bzr merge lp:~raharper/curtin/trunk.fix-vmtest-install-ok-check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Scott Moser (community) | Approve | ||
Review via email: mp+277908@code.launchpad.net |
Description of the change
Modify how vmtests checks if a curtin install was successful.
1. we missed finding failed installs on precise/trusty due to non-systemd output. systemd prepends non-pid-1 process output to console with the calling process, so we had 'cloud-init[.*]', however on pre-systemd systems, that's not present. Fix this by dropping the cloud-init portion of the regular expression
2. Add in additional error messages we've seen during debugging of test cases
3. Modify the check to first see if we can find curtin's successful install message; if that's not found, then look for common errors.
To post a comment you must log in.
I like this a lot, the only thing i hesitate on is jenkins running. we want to make sure console logs or artifacts there have everything we can to debug.
Diogo, could you run some and give us a pointer?