curtin

Merge lp:~raharper/curtin/trunk.fix-lp1615780 into lp:~curtin-dev/curtin/trunk

  1. trunk.fix-lp1615780
  2. Merge into trunk
Proposed by Ryan Harper
Status: Merged
Merged at revision: 419
Proposed branch: lp:~raharper/curtin/trunk.fix-lp1615780
Merge into: lp:~curtin-dev/curtin/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
curtin/commands/apply_net.py (+1/-0)
To merge this branch: bzr merge lp:~raharper/curtin/trunk.fix-lp1615780
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
curtin developers Pending
Review via email: mp+303619@code.launchpad.net

Description of the change

curtin.apply_net should exit non-zero upon exception

Using curtin apply_net on the cli does not exit non-zero when
encountering an exception.

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:417
https://jenkins.ubuntu.com/server/job/curtin-ci/248/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=amd64/248
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=ppc64el/248

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/248/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'curtin/commands/apply_net.py'
2--- curtin/commands/apply_net.py 2016-07-13 07:50:49 +0000
3+++ curtin/commands/apply_net.py 2016-08-22 19:40:31 +0000
4@@ -78,6 +78,7 @@
5 network_config=state['network_config'])
6 except Exception:
7 LOG.exception('failed to apply network config')
8+ return 1
9
10 LOG.info('Applied network configuration successfully')
11 sys.exit(0)

Subscribers

People subscribed via source and target branches