lp:~raharper/curtin/trunk.fix-iscsi-shutdown

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 523

Server Team CI bot: Approve (continuous-integration) on 2017-09-01

Chad Smith: Approve on 2017-09-01

Nish Aravamudan: Pending requested 2017-08-30

Diff: 298 lines (+227/-5)

4 files modified

curtin/block/iscsi.py (+35/-3)
curtin/commands/install.py (+7/-2)
tests/unittests/test_block_iscsi.py (+181/-0)
tests/vmtests/test_lvm_iscsi.py (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1713537: iscsi-targets don't quit session on shutdown

Medium

Fix Released

Link a bug report

Related blueprints

533. By Ryan Harper on 2017-08-31

Add unittest for parsing storage config for iscsi disks

532. By Ryan Harper on 2017-08-31

Clean up logging messages

531. By Ryan Harper on 2017-08-31

config is a list

530. By Ryan Harper on 2017-08-31

Parse storage config for reconstructing iscsi disk objects for disconnect operations

529. By Ryan Harper on 2017-08-30

Don't use iscsi globals, not available across stages

The iscsi global is not available across stages due to use of
subprocess to run curtin commands. Revert back to finding
on-disk sessions that curtin configured to run iscsi disconnects.

528. By Ryan Harper on 2017-08-30

Switch back to unmounting all paths, and then disconnecting iscsi

In general, the typical cleanup of an in-use of block device involves
unmounting the filesystem/block device, and then perform any block
device specific actions. In this case, curtin will recursively unmount
any devices mounted under the install target directory (iscsi disks included)
And then we query the curtin iscsi layer for any connected iscsi devices it
created and invoke disconnect on each device. This should avoid shutting down
any other sessions which may be active but are not created/owned by curtin.

In addition, add some logging to some of the iscsi paths which previously
would silently exit without performing the requested action (disconnect for
example returns if the target iscsi node dir is not present).

527. By Ryan Harper on 2017-08-30

Don't rely on ephemeral env, use target iscsi config, disconnect before unmount

526. By Ryan Harper on 2017-08-29

Add unittests for iscsi.disconnect_target_disks

525. By Ryan Harper on 2017-08-29

Check if target is in active session, else skip disconnect

524. By Ryan Harper on 2017-08-29

iscsi: disconnect prior to unmounting target