lp:~raharper/curtin/trunk.fix-bionic-netdeps
- Get this branch:
- bzr branch lp:~raharper/curtin/trunk.fix-bionic-netdeps
Branch merges
- Scott Moser (community): Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 20 lines (+3/-6)1 file modifiedcurtin/commands/curthooks.py (+3/-6)
Branch information
Recent revisions
- 546. By Ryan Harper
-
Allow control of curtin install unmounting
A Curtin install always unmounts the target. In the subiquity use-case
they would like to support a) if something goes wrong give a shell to
the user to poke around in the target b) skip unmounting automatically
to allow writing of additional files in the target without re-invoking
curtin c) control where curtin mounts up storage devices.This branch adds two fields to the curtin 'install' config key: The
'target' value is a path that will be used instead of a temporary
directory. The 'unmount' key if found to be present and has the value
of 'disabled' then curtin install will skip the unmount operation.Additionally to aid in unmounting a target outside of the install
subcommand this branch introduces a curtin 'unmount' subcommand which
takes two params: the 'target' path to the mount point, the default
'target' value is to use the TARGET_MOUNT_POINT environment variable.
Curtin will by default do unmounts in a recursive manner meaning any
directory mounted underneath the target will also be unmounted. A user
may supply '--disable-recursive- mounts' as a flag which will disable
the recursion resulting in a single unmount operation. - 544. By Ryan Harper
-
storage: add 'options' key mount type to specify mount parameters for filesystems
Add support, documentation, unittests and vmtests to deliver a new parameter to
the mount configuration dictionary. This parameter if set will modify the the
mount options field in the rendered /etc/fstab.LP: #1709284
- 543. By Ryan Harper
-
Re-add curthooks.
write_files method for backwards compat In revno 512, curthooks.
write_files( ) was re-implemented under
curtin.futil.write_ files and supports the original dictionary
format as well as other modes. This broke legacy images which used
hooks that invoked curthooks.write_files. This branch restores
the function and behavior while utilizing the change in implementation.- Add warning when legacy path is called pointing to new module location
- Add unittests to exercise the code path.LP: #1731709
- 542. By Scott Moser
-
vmtest: Remove ArtfulTestBridging skip_by_date check, bug fixed
Bug 1721157 is now fixed, so do not need to skip by date anymore.
- 540. By Ryan Harper
-
clear_holders: bcache log IO/OS exceptions but do not raise
While stopping bcache devices, curtin races with the kernel w.r.t how
quickly it removes the bcache device (and the sysfs tree related).
The result is that as curtin attempts to write "1" into the sysfs tree
of bcache device to stop it, the range of errors changes depending on
when we race with the kernel asynchronously removing the sysfs path.
Therefore we log the exception errno we got but do not re-raise. The
the calling process is watching whether the same sysfs path is being
removed; if the bcache device fails to go away then curtin will have a
log of the exceptions to debug. - 539. By Scott Moser
-
vmtest: Support newer qemu and multipath.
If you pass the same backing device for a disk to qemu, newer
versions (2.10+) will fail. In order to allow this, it requires
you to pass 'file.locking=off'.This change makes the multipath tests add a 'file.locking=off' argument
to the disks that are actually intended to be added more than once.
xkvm is modified to remove that flag if the qemu being used does not
support it.In order to accomplish this:
a.) make launch use xkvm '--disk' for all its disks rather than
passing -drive and -device. This is good in that we know have
a single way of passing disks around.
b.) fix a logic bug in xkvm when --disk= specified format= on it.vmtest and launch now only use '--disk=' args, which are interpreted
by xkvm rather than using a mix of '--disk=' and '-drive'. - 538. By Ryan Harper
-
block: enable control over exclusive_open use when wiping volumes
The exclusive_open check on a device is very useful to determine if
curtin is removing all metadata from a device w.r.t storage
configuraiton. However, in some cases during creation of new storage
configations when curtin attempts to add additional partitions to a
device that has partitions already added to an raid device, the
exclusive open is blocked while we attempt to zero some data on the
underlying device. The Mirrorboot-UEFI vmtest exemplifies this
situation.This patch exposes a flag to the zero_file_at_offset method to allow
callers (block_meta in this case) to disable the exclusive_open. This
lets curtin wipe data at specific offsets on a volume without
requiring exclusive ownership of the device.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~curtin-dev/curtin/trunk