lp:~raharper/curtin/trunk.fix-bcache-sysfs-write-failures-on-remove

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 535

Server Team CI bot: Approve (continuous-integration) on 2017-10-13

Chad Smith: Approve on 2017-10-13

Scott Moser (community): Needs Information on 2017-10-12

Diff: 150 lines (+100/-4)

2 files modified

curtin/block/clear_holders.py (+18/-4)
tests/unittests/test_clear_holders.py (+82/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1700564: under heavy IO encounter TOCTOU bug with bcache removal

Medium

Fix Released

Link a bug report

Related blueprints

534. By Ryan Harper on 2017-10-13

Use common bcache_maybe_remove handler for simpler unittests

533. By Ryan Harper on 2017-10-12

Ensure we don't swallow all exceptions, only ENOENT

532. By Ryan Harper on 2017-10-12

merge from trunk

531. By Ryan Harper on 2017-10-05

Update unittest, using errno means we skip the os.path.exists check (which can race)

530. By Ryan Harper on 2017-09-29

Use errno.ENOENT to check for missing bcache stop file

529. By Ryan Harper on 2017-09-29

Add exception for logging

528. By Ryan Harper on 2017-09-29

merge from trunk

527. By Ryan Harper on 2017-09-14

merge from trunk

526. By Ryan Harper on 2017-09-14

bcache: accept sysfs write failure in shutdown handler if path missing

Bcache device shutdown is asynchronus. The kernel may remove the
device after we've tested to see if the device needs to be stopped but
before we issue a 'stop' command to the bcache sysfs file.

When that happens, curtin throws an exception; this patch catches
those and tests if the target path is missing; and if so, ignores the
error as it's expected due to device removal.

All other write failures where the path is still present are still
valid and reported.

LP: #1700564

525. By Ryan Harper on 2017-09-07

mdadm: handle write failures to sysfs entries when stopping mdadm

mdadm_stop command tries a number of methods to stop an existing
array. Writes to sysfs fail differently, this patch catches both
IOErrors and OSErrors when writing to sysfs entries, logs and continues
with the stop operation.

Updating the LVM over RAID vmtest to run in dirty_disk mode reproduces
a failure reported and is resolved with this branch.

LP: #1708052