lp:~raharper/curtin/fix-lp1531520

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~curtin-dev/curtin/trunk at revision 336

Server Team CI bot: Approve (continuous-integration) on 2016-01-07

curtin developers: Pending requested 2016-01-06

Diff: 340 lines (+84/-53)

3 files modified

curtin/block/mdadm.py (+38/-22)
curtin/commands/block_meta.py (+7/-7)
tests/unittests/test_block_mdadm.py (+39/-24)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1531520: raid preserve issues discovered upon use from block_meta

Medium

Fix Released

Link a bug report

Related blueprints

340. By Ryan Harper on 2016-01-07

from trunk

339. By Ryan Harper on 2016-01-07

Introduce assert_valid_devpath

Reduce duplicate code of raising ValueError when provided an invalid devpath.

338. By Ryan Harper on 2016-01-07

Use common message formatting when raising ValueError exceptions

337. By Ryan Harper on 2016-01-06

mdadm, block_meta: enforce use of devpath when specifying device names

Ensure all entry-points in mdadm which expect a device name are prefixed
with /dev/ otherwise raise a ValueError. This aides in finding code paths
which may pass in storage ids instead of looking doing a lookup on the id
and determining the device path.

336. By Ryan Harper on 2016-01-06

mdadm_create: raise exception if passed an invalid md_devname

335. By Ryan Harper on 2016-01-06

mdadm: don't attempt to convert degraded to integer

There's no need to convert attribute to integer, instead just
check if it isn't "0", ie, not degraded.

334. By Ryan Harper on 2016-01-06

md_sysfs_attr: fix inverted logic on isfile check

Ensure we attempt to load the contents of a file if it is a file.
Replace open-coded call to open with util.load_file()

333. By Ryan Harper on 2016-01-06

md_check function is part of the block.mdadm module

When running raid with 'preserve' flag raised, the code called
md_check from the wrong module.

332. By Scott Moser on 2016-01-05

fix bug in install_grub to partition when storage_config provided.

when installing with a storage config and grub is to be installed
on a partition (as it is in powerpc) we were not able to look
up the device that was to be installed on.

This puts a temporary bit of code in place that finds that device
via imports from commands.block_meta. The result is that
storage_config now works for lvm on power8 systems.

331. By Scott Moser on 2016-01-04

url_helper: raise import error on lack of oauth only when oauth is used

Previously url_helper.py would raise exception if no oauth module
was present. That is definitely reasonable.

However, in the jenkins 'vmtest' test environment there was no oauth
available. Everything else would have been fine, and only
'curtin pack' is executed from the host. It feels like curtin pack
is sane to want to run with minimal dependencies.

I do definitely want to be careful with the dynamic manner here.
However, outside of MAAS reporter using oauth, it really is a unlikely
path to be hit. And MAAS's use case is still satisfied because
--install-deps is provided.