Last commit made on 2020-05-14
Get this branch:
git clone -b master https://git.launchpad.net/~raharper/curtin
Only Ryan Harper can upload to this branch. If you are Ryan Harper please log in for upload directions.

Branch merges

Branch information


Recent commits

c816305... by James Falcon on 2020-05-14

Replace references to old team manager with new team manager

aca7ba6... by Paride Legovini on 2020-05-14

tox: pin flake8 to version and add a tip-flake8 environment

Let's have a stable py3-flake8 tox environment that we run
as part of the CI, and a tip-flake8 environment we can run
in a separate job (or manually) to check the compliance
with the newer flake8 versions, without braking the CI.

537890a... by Lucas Albuquerque Medeiros de Moura on 2020-05-13

Fix flake8 E741 warning

6cbdc02... by Ryan Harper on 2020-05-07

Makefile: make adjustments to call lint/style tools via python module

- Drop nosetest invocation
- Drop tools/run-pyflakes*
- Add pylint targets
- Add pylintopts and target_dirs
- Fix style and lint issues

145e493... by Ryan Harper on 2020-05-07

block-discover: ignore invalid id_serial/id_wwn values

When obtaining unique ids for identifying a block storage
device, block-discover looks for ID_WWN and ID_SERIAL values
and will use them in the rendered storage config. In some cases
the value of these attributes may be invalid. For example, some
consumer disks might have an invalid WWN number:


Curtin will also ignore empty values, like

Excluded ids will not be emitted in the final storage config.

LP: #1876848

8ab48f6... by Ryan Harper on 2020-05-06

Fix handing of reusing msdos partitions and flags

Disks with an MSDOS partition table and one partition with the
'bootable' flag set exposed a parsing error in block.sfdisk_info;
further digging revealed that curtin was not setting the bootable
flag on MSDOS partitions when required. Not setting isn't fatal,
grub still boots the partition, but we should set the flag if told
to do so. Additionally storage-config conversion of probe data
where the MSDOS boot flag is set was missing. The following changes
are done to fix this issue

- switch to sfdisk --json output and use/introduce util.load_json()
- block-meta: update parted command to set boot flag if present
- block-discover: prefer ID_PART_ENTRY_FLAGS when present, and 0x80
- Add vmtest to verify reuse of msdos partition and bootable flag
- Fix boot, extended, logical flag verfication
- Fix extended partition size verification

LP: #1875903

f4bd38f... by Michael Hudson-Doyle on 2020-05-05

block.detect_multipath: ignore fake "devices" from /proc/mounts

A tmpfs can be mounted with any old junk in the "device" field and
unfortunately casper sometimes puts "/dev/shm" there, which is usually a
directory. Ignore such cases.

LP: #1876626

9b99e4b... by Ryan Harper on 2020-04-29

udev: use shlex.quote when shlex.split errors on shell-escape chars

The udev database may include shell escape characters in the output.
We want to avoid using shlex_quote unless needed as curtin does not
use the quoted value in our code and applying it to all of the values
breaks parsing of the udevadm info content.

If we encounter a ValueError while invoking shlex.split() then we
first use shlex_quote() and try parsing again and if that fails we
will try replacing shell-quote values with '_'. We log warning
whenever we have to quote or replace values.

- Python2.7 does not have shlex.quote, use pipes.quote (which was
  renamed to shlex.quote in Py3:
- Add unittest with original info dump from bug submitters system

LP: #1875085

f47a4c2... by Ryan Harper on 2020-04-29

lvm: don't use vgscan --mknodes

vgscan --mknodes has a bug which creates block device nodes for any
entry in dmsetup table if it doesn't exist yet. This breaks the
assumption that /dev/mapper entries are symlinks created by udev.
Until upstream RHBZ: #1828617 is resolved do not use --mknodes.

9d85462... by Ryan Harper on 2020-04-28

vmtest: rsync don't cross filesystem boundaries when copying

In some scenarios /var/lib/lxcfs is mounted with kernel bits
and rsync complains; instead we now copy using the --one-file-system
flag which avoids crossing these boundaries.

LP: #1873909