~raharper/curtin:fix/block-sfdisk-parsing

Branch merges

Propose for merging

Merged into curtin:master

Dan Watkins (community): Approve on 2020-05-06

Server Team CI bot: Approve (continuous-integration) on 2020-05-05

Michael Hudson-Doyle: Approve on 2020-04-30

Diff: 627 lines (+409/-69)

8 files modified

curtin/block/__init__.py (+44/-31)
curtin/commands/block_meta.py (+44/-13)
curtin/storage_config.py (+39/-24)
curtin/util.py (+9/-0)
examples/tests/reuse-msdos-partitions.yaml (+77/-0)
tests/unittests/test_block.py (+74/-0)
tests/unittests/test_commands_block_meta.py (+91/-1)
tests/vmtests/test_reuse_msdos_partitions.py (+31/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

b584b27... by Ryan Harper on 2020-05-05

Simplfy config by dropping secondary disk and lvm config

87d75fa... by Ryan Harper on 2020-05-05

Rewrite comment in vmtest scenario to suit.

447466d... by Ryan Harper on 2020-05-05

Move runtime check on sfdisk_info return value at start of partition verify

6e5f001... by Ryan Harper on 2020-05-05

Refactor partition table type MAPs join them and reuse the lookup

d22a1c7... by Ryan Harper on 2020-05-05

Don't build a single list of multiple dictionary keys

- Also use the correct block function for getting partition sfdisk
  info.

99c9f3d... by Ryan Harper on 2020-04-30

Add some Additional test-cases, move sfdisk part finder to block

70b562e... by Ryan Harper on 2020-04-30

Add unittest for block.sfdisk_info

3a6e711... by Ryan Harper on 2020-04-29

Fix up pyflakes

401073b... by Ryan Harper on 2020-04-29

Make reuse msdos partitions verify and work

5d313e1... by Ryan Harper on 2020-04-29

Fix handing of reusing msdos partitions and flags

Disks with an MSDOS partition table and one partition with the
'bootable' flag set exposed parsing error in block.sfdisk_info;
further digging revealed that curtin was not setting the bootable
flag on MSDOS partitions when required. Not setting isn't fatal,
grub still boots the partition, but we should set the flag if told
to do so. Additionally storage-config conversion of probe data
where the MSDOS boot flag is set was missing. The following changes
are done to fix this issue

- switch to sfdisk --json output and use/introduce util.load_json()
- block-meta: update parted command to set boot flag if present
- block-discover: prefer ID_PART_ENTRY_FLAGS when present, and 0x80
- Add vmtest to verify reuse of msdos partition and bootable flag