Merge ~raharper/curtin:fix/multiple-carry-over-param-separators into curtin:master
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Approved by: | Ryan Harper |
Approved revision: | beafd4b0f34d6e3f56e26a11cc85594d7fa290f5 |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~raharper/curtin:fix/multiple-carry-over-param-separators |
Merge into: | curtin:master |
Diff against target: |
64 lines (+18/-4) 2 files modified
curtin/commands/install_grub.py (+7/-2) tests/unittests/test_commands_install_grub.py (+11/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Approve | |
Dan Watkins (community) | Approve | ||
Review via email: mp+384469@code.launchpad.net |
Commit message
Handle multiple separators which were found in TestAllindata vmtest
TestAllindata specifies additional kernel args and include the '---'
separator. vmtest baseclass already includes a '---' and after
landing of the grub refactor, the python version of the
get_carryover_
Fix this by combining any args after the first '---' separator.
To post a comment you must log in.
PASSED: Continuous integration, rev:beafd4b0f34 d6e3f56e26a11cc 85594d7fa290f5 /jenkins. ubuntu. com/server/ job/curtin- ci/123/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-amd64/ 123/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-arm64/ 123/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-ppc64el/ 123/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-s390x/ 123/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/curtin- ci/123/ /rebuild
https:/