curtin

Merge ~raharper/curtin:fix/py27-setuptools-less-that-45 into curtin:master

  1. Git
  2. lp:~raharper/curtin
  3. fix/py27-setuptools-less-that-45
  4. Merge into master
Proposed by Ryan Harper
Status: Merged
Approved by: Ryan Harper
Approved revision: 9bfb20e5a02d761c9904546a98401c18297e9724
Merge reported by: Server Team CI bot
Merged at revision: not available
Proposed branch: ~raharper/curtin:fix/py27-setuptools-less-that-45
Merge into: curtin:master
Diff against target: 13 lines (+2/-0)
1 file modified
tox.ini (+2/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Chad Smith Approve
Review via email: mp+380183@code.launchpad.net

Commit message

tox: pin setuptools < 45 to allow installing py27 in virtenv

setuptools release 45 broke everyone who installed py27[1]. Fix
this by using the previous release.

1. https://github.com/pypa/setuptools/issues/1963

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) :
review: Needs Fixing
~raharper/curtin:fix/py27-setuptools-less-that-45 updated
9bfb20e... by Ryan Harper

Add github issue related to the change

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:1ef748d58bc3d68bb240ec572fbe5badea653a31
https://jenkins.ubuntu.com/server/job/curtin-ci/3853/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/3853/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/3853/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/3853/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=torkoal/3853/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/3853//rebuild

review: Approve (continuous-integration)
Revision history for this message
Chad Smith (chad.smith) wrote :

WFM

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:9bfb20e5a02d761c9904546a98401c18297e9724
https://jenkins.ubuntu.com/server/job/curtin-ci/3855/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/3855/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/3855/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/3855/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=torkoal/3855/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/3855//rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tox.ini b/tox.ini
2index 3a8e40e..dad09cc 100644
3--- a/tox.ini
4+++ b/tox.ini
5@@ -29,6 +29,8 @@ basepython = python3
6
7 [testenv:py27]
8 basepython = python2.7
9+# https://github.com/pypa/setuptools/issues/1963
10+deps = setuptools<45
11
12 # tox uses '--pre' by default to pip install. We don't want that, and
13 # 'pip_pre=False' isn't available until tox version 1.9.

Subscribers

People subscribed via source and target branches