Merge ~raharper/curtin:fix/vmtest-network-vlan-skip into curtin:master
Proposed by
Ryan Harper
Status: | Merged |
---|---|
Approved by: | Dan Watkins |
Approved revision: | c2a81ed20a4ea51ec09cab88307d7326e9acd1cb |
Merge reported by: | Server Team CI bot |
Merged at revision: | not available |
Proposed branch: | ~raharper/curtin:fix/vmtest-network-vlan-skip |
Merge into: | curtin:master |
Diff against target: |
42 lines (+6/-6) 2 files modified
tests/vmtests/test_network_ipv6_vlan.py (+2/-2) tests/vmtests/test_network_vlan.py (+4/-4) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dan Watkins (community) | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+378546@code.launchpad.net |
Commit message
vmtests: bump fixby date out and fix false positive when date passes
The fix for vlan is still pending, however we've observed a false
positive where vmtest would indicate that the test was passing when
it actually was not. This is because skip_by_date will run the
decorated function *after* the fixby date has passed. The
implementation was 'pass' which does pass but did not actually run
the test case.
Fix this by calling to the super class.
LP: #1855148
To post a comment you must log in.
PASSED: Continuous integration, rev:c2a81ed20a4 ea51ec09cab8830 7d7326e9acd1cb /jenkins. ubuntu. com/server/ job/curtin- ci/3832/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-arm64/ 3832/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-ppc64el/ 3832/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= metal-s390x/ 3832/ /jenkins. ubuntu. com/server/ job/curtin- ci/nodes= torkoal/ 3832/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/server/ job/curtin- ci/3832/ /rebuild
https:/