Code review comment for ~raharper/curtin:fix/ptable-label-pmbr

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

No, that is not the right thing to do from the point of preservation of partition table.

partition tables that curtin doesn't know how to manipulate (ie. create table, create/change partitions) it should be emitted as unknown or frozen.

Kernel can parse the partitions, thus one can reuse those partitions.

A device without a partition table, is different to a device with an unknown partition table we don't know how to modify correctly.

Thus completely omitting partition table, seems, conceptually, to me like a lie.

review: Needs Fixing

« Back to merge proposal