Merge ~raharper/curtin:fix/iscsi-dirty-disk-mode into curtin:master

Proposed by Ryan Harper
Status: Merged
Approved by: Scott Moser
Approved revision: 9a0469c92371e632480d6f991d50516d5eda75c6
Merged at revision: 61469b5b769f399fdf63027c8864f20fc5b31c9a
Proposed branch: ~raharper/curtin:fix/iscsi-dirty-disk-mode
Merge into: curtin:master
Diff against target: 12 lines (+1/-0)
1 file modified
tests/vmtests/test_mdadm_iscsi.py (+1/-0)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Scott Moser (community) Needs Fixing
Review via email: mp+340948@code.launchpad.net

Description of the change

Disable dirty_disks mode for mdadm + iscsi tests

Two issues with dirty_disk mode. First, after the early
stage runs, we need to tear down the raid array so we can
disconnect the iscsi devices, second even when that is done
there is a bug in mdadm version in Artful and Bionic which
prevents successful testing (LP: #1753786)

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Scott Moser (smoser) :
review: Needs Fixing
Revision history for this message
Ryan Harper (raharper) wrote :

Added comment to the line in the test-case file referencing the bug.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/vmtests/test_mdadm_iscsi.py b/tests/vmtests/test_mdadm_iscsi.py
2index 9c028dc..3c8e6ef 100644
3--- a/tests/vmtests/test_mdadm_iscsi.py
4+++ b/tests/vmtests/test_mdadm_iscsi.py
5@@ -9,6 +9,7 @@ import textwrap
6
7 class TestMdadmIscsiAbs(TestMdadmAbs, TestBasicIscsiAbs):
8 interactive = False
9+ dirty_disks = False # LP: 1753786
10 iscsi_disks = [
11 {'size': '5G', 'auth': 'user:passw0rd'},
12 {'size': '5G', 'auth': 'user:passw0rd', 'iauth': 'iuser:ipassw0rd'},

Subscribers

People subscribed via source and target branches