Code review comment for ~raharper/cloud-init:fix/ephemeral-dhcp-static-routes

Revision history for this message
Dan Watkins (oddbloke) wrote :

Wow, what an annoying format to have to parse. Overall, I think this looks good; I have a couple of inline comments. I'd also like to see us expand the unit testing of the parsing code so that we're at least covering every branch in there (and ideally doing at least one test with a bunch combined, to make sure that our skip lengths are accurate).

review: Needs Fixing

« Back to merge proposal