Code review comment for ~raharper/cloud-init:snapuser-create
Revision history for this message
| Scott Moser (smoser) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
over all, looks good.
you dont have to clean up the handle, but if you see easy way to do that that'd be nice.
is the snappy path now valid on non-snappy system ? (ubuntu server with 'snap' support).
lastly, please just review your commit message and make sure its up to date with all changes (it may well be, just think you made some changes since you wrote it).