Ubuntu
targetcli-fb package

Code review comment for ~rafaeldtinoco/ubuntu/+source/targetcli-fb:focal-merge-upstream-2.1.51

  1. Git
  2. lp:~rafaeldtinoco/ubuntu/+source/targetcli-fb
  3. focal-merge-upstream-2.1.51
  4. Merge into ubuntu/focal-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I really think we need to do more for targetclid (https://github.com/open-iscsi/targetcli-fb/commit/7917ef55f6279fa28519d2160c4ec49453c275ec)

- ./usr/bin/targetclid in installed but missing a man page.

- try the new socket activation (daemon is still off by default https://github.com/open-iscsi/targetcli-fb/commit/797778eeb2997d34af7fd3760195f7f8d08470f4)

- changelog needs epoch mentioned (uh I just found there even is a lintian entry for it https://lintian.debian.org/tags/epoch-change-without-comment.html)

- we miss the targetclid.service/socket (https://github.com/open-iscsi/targetcli-fb/commit/ad37f94ae72d0e3d5963ce182e2897c84af9c039)

Summary:
- I'm glad it is still off by default, things will work as before
- We need to package targetclid better
- we need to test and fix targetclid (can be done after FF)

« Back to merge proposal