Code review comment for ~rafaeldtinoco/ubuntu/+source/qemu:lp1828495-bionic-devel-qemu

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

E165: Cannot go beyond last file
Ok, it seems I'm done for now.

Sorry for so much requests to change, but I think it overall is already good.
Yet doing as I requested will fix some remaining issues and make the porting to other Ubuntu Releases easier. So I hope you can forgive me :-/

I'd recommend you to keep this branch as reference - otherwise my comments which refer to patch numbers might be hard to track.

I saved it as lp1828495-bionic-devel-qemu-OLD myself as I assume that you'll later on force push something that looks way different than what we have now :-)

Please feel free to discuss if anything is unclear and ping me when I should re-review this.

« Back to merge proposal