Merge ~rafaeldtinoco/ubuntu/+source/net-snmp:lp1855943-focal into ubuntu/+source/net-snmp:debian/sid

Proposed by Rafael David Tinoco
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 50b42af6a38c2d07012bdea6bd32d887970c9822
Merge reported by: Rafael David Tinoco
Merged at revision: 50b42af6a38c2d07012bdea6bd32d887970c9822
Proposed branch: ~rafaeldtinoco/ubuntu/+source/net-snmp:lp1855943-focal
Merge into: ubuntu/+source/net-snmp:debian/sid
Diff against target: 1477 lines (+1238/-4)
10 files modified
debian/changelog (+821/-0)
debian/control (+4/-3)
debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch (+32/-0)
debian/patches/autofs-fix-a-recently-introduced-bug.patch (+36/-0)
debian/patches/autofs-skip-autofs-entries.patch (+237/-0)
debian/patches/fix-check-hr-filesys-autofs.patch (+36/-0)
debian/patches/mysql8-replace-bool.patch (+26/-0)
debian/patches/series (+5/-0)
debian/rules (+5/-1)
debian/source.apport (+36/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server packageset reviewers Pending
Canonical Server Core Reviewers Pending
Canonical Server Pending
Review via email: mp+376795@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

From previous (Already done) work:

https://code.launchpad.net/~rafaeldtinoco/+git/net-snmp/+merge/376741/comments/987513

Continuing work here...

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Still functionally correct, continuing our discussion on better headers/changelog in some inline comments.

Once you fixed those please ping me, other than that it functionally LGTM already

review: Needs Fixing
22e8f10... by Rafael David Tinoco

 * Skip autofs entries when calling statfs to prevent autofs
   being mounted on snmpd startup (LP: #1835818):
   - d/p/autofs-fix-a-recently-introduced-bug.patch
   - d/p/autofs-skip-autofs-entries.patch

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Fixing after your last review and re-pushing.

Thanks for reviewing this!

Obs: mind pushing into the repo if no other changes are needed ?

Thanks!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Looking again ...

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks for fixing those up.
Sorry I have bothered with that so much, but you'll see that it will help all of us on the continued maintenance of this.

All I requested is now present - thanks.
I pushed the tag, but before sponsoring I'll apply the full review template to be sure I'm not missing something.

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/net-snmp
 * [new tag] upload/5.8+dfsg-2ubuntu1 -> upload/5.8+dfsg-2ubuntu1

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [√] old content and logical tag match as expected
- [√] changelog entry correct version and targeted codename
- [√] changelog entries correct
- [√] update-maintainer has been run

Actual changes:
- [√] no major upstream changes to consider (looks like good fixes to me)
- [√] no further upstream version to consider
- [√] debian changes look safe to me

Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop
- [√] changes forwarded upstream/debian (if appropriate)

New Delta:
- [√] new patches are good or match what was proposed upstream (refreshing old ones)
- [√] new patches correctly included in debian/patches/series?
- [√] new patches have correct DEP3 metadata

Build/Test:
- [√] build is ok
- [√] sanity checks test fine

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading net-snmp_5.8+dfsg-2ubuntu1.dsc: done.
  Uploading net-snmp_5.8+dfsg.orig.tar.xz: done.
  Uploading net-snmp_5.8+dfsg-2ubuntu1.debian.tar.xz: done.
  Uploading net-snmp_5.8+dfsg-2ubuntu1_source.buildinfo: done.
  Uploading net-snmp_5.8+dfsg-2ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8482bb7..d682db3 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,36 @@
6+net-snmp (5.8+dfsg-2ubuntu1) focal; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1855943). Remaining changes:
9+ - d/p/fix-check-hr-filesys-autofs.patch (LP #1843036)
10+ - Skip autofs entries when calling statfs (LP #1835818):
11+ - d/p/autofs-skip-autofs-entries.patch
12+ - d/p/autofs-fix-a-recently-introduced-bug.patch
13+ [Replaced former Non-upstream patches with clean cherry-pick)
14+ - d/p/mysql8-replace-bool.patch: fix build with mysql-8 (LP 1814270)
15+ - d/p/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch: Link
16+ libnetsnmptrapd against MYSQL_LIBS.
17+ - Add apport hook.
18+ - d/control: add dh-apport to Build-Depends
19+ - d/rules: install the apport hook via debhelper
20+ - d/source.apport: apport hook
21+ * Dropped patches that are upstream and in Debian 5.8+dfsg-2:
22+ - d/p/put-paranthesis-around-macros-which-are-expressions.patch
23+ (LP #1843036)
24+ - Fix build with mysql-8 (LP #1814270):
25+ - d/p/mysql-options.patch: use mysql_options if no {my_,}load_defaults
26+ was found.
27+ - d/p/mysql-init.patch: handle the various mysql init functions.
28+ - d/p/mysql8-headers.patch: detect if my_global.h and my_sys.h are
29+ available.
30+ - d/p/my-load-defaults.patch: properly detect (and use)
31+ my_load_defaults().
32+ - d/p/snmptrapd_mysql_init: no need to drop this patch anymore
33+ (LP #1814254)
34+ - d/p/0001-swinst_apt.c-Fix-indexing-of-hrSWInstalledTable-to-s.patch
35+ (LP #1314760)
36+
37+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Fri, 13 Dec 2019 03:27:52 +0000
38+
39 net-snmp (5.8+dfsg-2) unstable; urgency=medium
40
41 * All MIB directory values removed and just use the default compile-time
42@@ -30,6 +63,87 @@ net-snmp (5.8+dfsg-1) unstable; urgency=medium
43
44 -- Craig Small <csmall@debian.org> Thu, 10 Oct 2019 22:37:15 +1100
45
46+net-snmp (5.7.3+dfsg-5ubuntu6) focal; urgency=medium
47+
48+ * No-change rebuild for the perl update.
49+
50+ -- Matthias Klose <doko@ubuntu.com> Fri, 18 Oct 2019 19:37:07 +0000
51+
52+net-snmp (5.7.3+dfsg-5ubuntu5) eoan; urgency=medium
53+
54+ * d/p/fix-check-hr-filesys-autofs.patch:
55+ - On Linux getmntent() is available but getfsstat() not.
56+ Hence remove #if HAVE_GETFSSTAT from around the HRFS_type
57+ check.
58+
59+ -- Eric Desrochers <eric.desrochers@canonical.com> Sat, 07 Sep 2019 16:30:53 +0000
60+
61+net-snmp (5.7.3+dfsg-5ubuntu4) eoan; urgency=medium
62+
63+ * d/p/put-paranthesis-around-macros-which-are-expressions.patch:
64+ - put paranthesis around macros which are expressions.
65+ (LP: #1843036)
66+
67+ -- Eric Desrochers <eric.desrochers@canonical.com> Fri, 06 Sep 2019 23:15:43 +0000
68+
69+net-snmp (5.7.3+dfsg-5ubuntu3) eoan; urgency=medium
70+
71+ * Skip autofs entries when calling statfs to prevent autofs being mounted on
72+ snmpd startup (LP: #1835818):
73+ - d/p/autofs-skip-autofs-entries.patch
74+ - d/p/autofs-fix-a-recently-introduced-bug.patch
75+
76+ -- Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com> Wed, 21 Aug 2019 12:22:37 +0100
77+
78+net-snmp (5.7.3+dfsg-5ubuntu2) eoan; urgency=medium
79+
80+ * No change rebuild for libmysqlclient21.
81+
82+ -- Robie Basak <robie.basak@ubuntu.com> Mon, 12 Aug 2019 11:32:18 +0000
83+
84+net-snmp (5.7.3+dfsg-5ubuntu1) disco; urgency=medium
85+
86+ * Merge with Debian unstable. Remaining changes:
87+ - Add apport hook.
88+ + d/control: add dh-apport to Build-Depends
89+ + d/rules: install the apport hook via debhelper
90+ + d/source.apport: apport hook
91+ - d/p/0001-swinst_apt.c-Fix-indexing-of-hrSWInstalledTable-to-s.patch:
92+ set first hrSWInstalledIndex to 1 to follow RFC 2790 (LP #1314760)
93+ * Drop:
94+ - SECURITY UPDATE: DoS via NULL pointer exception
95+ + debian/patches/CVE-2018-18065.patch: fix logic in
96+ agent/helpers/table.c.
97+ + CVE-2018-18065
98+ [Fixed in 5.7.3+dfsg-4]
99+ - d/p/my_load_defaults: use my_load_defaults instead of the
100+ libmysqlclient-internal load_defaults (LP #1565003). Thanks to Lars
101+ Tangvald.
102+ [Replaced by a more complete patch]
103+ - debian/rules: Fix calculation of UPSTREAM_VERSION and COMPAT_VERSION.
104+ [No more needed since 5.7.3+dfsg-5]
105+ * Added:
106+ - d/p/snmptrapd_mysql_init: drop this patch. The first part fixes builds
107+ with newer mariadb, which Ubuntu doesn't use, and the second part is
108+ an unrelated change which we are fixing in another patch (see #1814254
109+ for details).
110+ - d/p/0001-Link-libnetsnmptrapd-against-MYSQL_LIBS.patch: Link
111+ libnetsnmptrapd against MYSQL_LIBS. Thanks to Adam
112+ Williamson <awilliam@redhat.com>. (Closes: #886221, LP: #1814254)
113+ - Fix build with mysql-8 (LP: #1814270):
114+ + d/p/mysql8-replace-bool.patch: newer mysql dropped my_bool, use char
115+ instead.
116+ + d/p/my-load-defaults.patch: properly detect (and use)
117+ my_load_defaults(). This replaces the previous
118+ my_load_defaults patch.
119+ + d/p/mysql8-headers.patch: detect if my_global.h and my_sys.h are
120+ available
121+ + d/p/mysql-init.patch: handle the various mysql init functions
122+ + d/p/mysql-options.patch: use mysql_options if no {my_,}load_defaults
123+ was found.
124+
125+ -- Andreas Hasenack <andreas@canonical.com> Tue, 05 Feb 2019 16:00:35 -0200
126+
127 net-snmp (5.7.3+dfsg-5) unstable; urgency=medium
128
129 * Use debhelper macros for shlibs Closes: #912685
130@@ -93,6 +207,60 @@ net-snmp (5.7.3+dfsg-2) unstable; urgency=medium
131
132 -- Craig Small <csmall@debian.org> Sat, 31 Mar 2018 20:00:51 +1100
133
134+net-snmp (5.7.3+dfsg-1.8ubuntu5) disco; urgency=medium
135+
136+ * No-change rebuild against latest lm-sensors
137+
138+ -- Jeremy Bicha <jbicha@ubuntu.com> Wed, 02 Jan 2019 17:37:45 -0500
139+
140+net-snmp (5.7.3+dfsg-1.8ubuntu4) disco; urgency=medium
141+
142+ * debian/rules: Fix calculation of UPSTREAM_VERSION and COMPAT_VERSION.
143+
144+ -- Adam Conrad <adconrad@ubuntu.com> Mon, 05 Nov 2018 13:22:39 -0700
145+
146+net-snmp (5.7.3+dfsg-1.8ubuntu3.18.10.1) cosmic-security; urgency=medium
147+
148+ * SECURITY UPDATE: DoS via NULL pointer exception
149+ - debian/patches/CVE-2018-18065.patch: fix logic in
150+ agent/helpers/table.c.
151+ - CVE-2018-18065
152+
153+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 22 Oct 2018 08:03:49 -0400
154+
155+net-snmp (5.7.3+dfsg-1.8ubuntu3) bionic; urgency=medium
156+
157+ * d/p/0001-swinst_apt.c-Fix-indexing-of-hrSWInstalledTable-to-s.patch:
158+ set first hrSWInstalledIndex to 1 to follow RFC 2790 (LP: #1314760)
159+
160+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Tue, 20 Feb 2018 15:24:41 +0100
161+
162+net-snmp (5.7.3+dfsg-1.8ubuntu2) bionic; urgency=high
163+
164+ * No change rebuild against openssl1.1.
165+
166+ -- Dimitri John Ledkov <xnox@ubuntu.com> Tue, 06 Feb 2018 17:54:39 +0000
167+
168+net-snmp (5.7.3+dfsg-1.8ubuntu1) bionic; urgency=medium
169+
170+ * Merge with Debian unstable (LP: #1742518). Remaining changes:
171+ - Add apport hook.
172+ + d/control: add dh-apport to Build-Depends
173+ + d/rules: install the apport hook via debhelper
174+ + d/source.apport: apport hook
175+ - d/p/my_load_defaults: use my_load_defaults instead of the
176+ libmysqlclient-internal load_defaults (LP #1565003). Thanks to Lars
177+ Tangvald.
178+ * Dropped:
179+ - Avoid installing links in rc[06].d.
180+ [It's not clear what it was trying to solve (no details or bug
181+ number), but update-rc.d no longer takes start/stop arguments and
182+ this delta was actually resulting in warnings during the installation.
183+ Also, Ubuntu is using systemd now and this package has systemd service
184+ files.]
185+
186+ -- Andreas Hasenack <andreas@canonical.com> Thu, 11 Jan 2018 16:07:07 -0200
187+
188 net-snmp (5.7.3+dfsg-1.8) unstable; urgency=medium
189
190 * Non-maintainer upload.
191@@ -104,6 +272,43 @@ net-snmp (5.7.3+dfsg-1.8) unstable; urgency=medium
192
193 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sat, 23 Dec 2017 23:48:23 +0100
194
195+net-snmp (5.7.3+dfsg-1.7ubuntu1) artful; urgency=medium
196+
197+ * Merge with Debian unstable (LP: #1712569). Remaining changes:
198+ - Add apport hook.
199+ + d/control: add dh-apport to Build-Depends
200+ + d/rules: install the apport hook via debhelper
201+ + d/source.apport: apport hook
202+ - Avoid installing links in rc[06].d.
203+ - d/p/my_load_defaults: use my_load_defaults instead of the
204+ libmysqlclient-internal load_defaults (LP #1565003). Thanks to Lars
205+ Tangvald.
206+ * Drop:
207+ - SECURITY UPDATE: denial of service and possible code execution via
208+ incompletely parsed varBind variables
209+ + debian/patches/CVE-2015-5621.patch: don't return incorrectly parsed
210+ varbinds in snmplib/snmp_api.c.
211+ + CVE-2015-5621
212+ [Added by Debian as 0025-Bug-788964-net-snmp-snmp_pdu_parse-DoS.patch
213+ in 5.7.3+dfsg-1.1]
214+ - debian/snmp.preinst:
215+ It turns out that the original motivation why killall was added is gone.
216+ So we can just remove the killall introduced by Ubuntu LP #573391
217+ (Closes: #781257, LP #1245604)
218+ [Fixed in Debian 5.7.3+dfsg-1.1]
219+ - Fix "FTBFS with Perl 5.24: error: conflicting types for 'U64'":
220+ add patch from upstream git which removes the U64 typedef from the
221+ Net-SNMP header files.
222+ Thanks to Niky Tyni for extracting the patch.
223+ (Closes: #825014)
224+ [Fixed in Debian 5.7.3+dfsg-1.5]
225+ - Additionally add another patch from upstream git which fixes
226+ perl/*/Makefile.PL to fix build failures with Perl 5.24.
227+ Cf. https://sourceforge.net/p/net-snmp/bugs/2712/
228+ [Fixed in Debian 5.7.3+dfsg-1.5]
229+
230+ -- Andreas Hasenack <andreas@canonical.com> Wed, 23 Aug 2017 10:29:35 -0300
231+
232 net-snmp (5.7.3+dfsg-1.7) unstable; urgency=medium
233
234 [ Niels Thykier ]
235@@ -227,6 +432,68 @@ net-snmp (5.7.3+dfsg-1.1) unstable; urgency=medium
236
237 -- Steinar H. Gunderson <sesse@debian.org> Tue, 29 Mar 2016 10:30:24 +0200
238
239+net-snmp (5.7.3+dfsg-1ubuntu6) artful; urgency=medium
240+
241+ * No-change rebuild for perl 5.26.0.
242+
243+ -- Matthias Klose <doko@ubuntu.com> Wed, 26 Jul 2017 20:11:36 +0000
244+
245+net-snmp (5.7.3+dfsg-1ubuntu5) zesty; urgency=medium
246+
247+ * Cherry-pick two patches from Debian's 5.7.3+dfsg-1.5:
248+ * Fix "FTBFS with Perl 5.24: error: conflicting types for 'U64'":
249+ add patch from upstream git which removes the U64 typedef from the
250+ Net-SNMP header files.
251+ Thanks to Niky Tyni for extracting the patch.
252+ (Closes: #825014)
253+ * Additionally add another patch from upstream git which fixes
254+ perl/*/Makefile.PL to fix build failures with Perl 5.24.
255+ Cf. https://sourceforge.net/p/net-snmp/bugs/2712/
256+
257+ -- Iain Lane <iain@orangesquash.org.uk> Tue, 25 Oct 2016 10:28:38 +0100
258+
259+net-snmp (5.7.3+dfsg-1ubuntu4) xenial; urgency=medium
260+
261+ * Rebuild against libmysqlclient20.
262+ * d/p/my_load_defaults: use my_load_defaults instead of the
263+ libmysqlclient-internal load_defaults (LP: #1565003). Thanks to Lars
264+ Tangvald.
265+
266+ -- Robie Basak <robie.basak@ubuntu.com> Tue, 05 Apr 2016 15:17:35 +0000
267+
268+net-snmp (5.7.3+dfsg-1ubuntu3) xenial; urgency=medium
269+
270+ * Rebuild for Perl 5.22.1.
271+
272+ -- Colin Watson <cjwatson@ubuntu.com> Fri, 18 Dec 2015 01:20:38 +0000
273+
274+net-snmp (5.7.3+dfsg-1ubuntu2) wily; urgency=medium
275+
276+ * debian/snmp.preinst:
277+ It turns out that the original motivation why killall was added is gone.
278+ So we can just remove the killall introduced by Ubuntu LP #573391
279+ (Closes: #781257, LP: #1245604)
280+
281+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Fri, 09 Oct 2015 13:18:25 +0200
282+
283+net-snmp (5.7.3+dfsg-1ubuntu1) wily; urgency=medium
284+
285+ * Resynchronise with Debian. Remaining changes:
286+ - Add apport hook.
287+ - Avoid installing links in rc[06].d.
288+ * Dropped patches included in new version:
289+ - debian/patches/00upstream-btrfs.patch
290+ - debian/patches/CVE-2012-6151.patch
291+ - debian/patches/CVE-2014-2284.patch
292+ - debian/patches/CVE-2014-2285.patch
293+ * SECURITY UPDATE: denial of service and possible code execution via
294+ incompletely parsed varBind variables
295+ - debian/patches/CVE-2015-5621.patch: don't return incorrectly parsed
296+ varbinds in snmplib/snmp_api.c.
297+ - CVE-2015-5621
298+
299+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 17 Aug 2015 12:58:43 -0400
300+
301 net-snmp (5.7.3+dfsg-1) unstable; urgency=medium
302
303 * Imported Upstream version 5.7.3+dfsg
304@@ -358,6 +625,56 @@ net-snmp (5.7.2.1~dfsg-1) experimental; urgency=medium
305
306 -- Hideki Yamane <henrich@debian.org> Sun, 30 Mar 2014 19:58:39 +0900
307
308+net-snmp (5.7.2~dfsg-8.1ubuntu5) utopic; urgency=medium
309+
310+ * Backport from 5.7.2.1~dfsg-6.1:
311+ - Fix "hardcodes /usr/lib/perl5":
312+ Make debian/libsnmp-perl.install executable and use
313+ $Config{vendorarch} to get the perl library directory. Patch from Niko
314+ Tyni.
315+ (Closes: #751918)
316+
317+ -- Colin Watson <cjwatson@ubuntu.com> Wed, 20 Aug 2014 11:16:35 +0100
318+
319+net-snmp (5.7.2~dfsg-8.1ubuntu4) utopic; urgency=medium
320+
321+ * Rebuild for Perl 5.20.0.
322+
323+ -- Colin Watson <cjwatson@ubuntu.com> Wed, 20 Aug 2014 00:21:26 +0100
324+
325+net-snmp (5.7.2~dfsg-8.1ubuntu3) trusty; urgency=medium
326+
327+ * SECURITY UPDATE: denial of service via AgentX subagent timeout
328+ - debian/patches/CVE-2012-6151.patch: track cancelled sessions in
329+ agent/mibgroup/agentx/{master.c,master_admin.c}, agent/snmp_agent.c,
330+ include/net-snmp/agent/snmp_agent.h.
331+ - CVE-2012-6151
332+ * SECURITY UPDATE: denial of service when ICMP-MIB is in use
333+ - debian/patches/CVE-2014-2284.patch: fix ICMP mib table handling in
334+ agent/mibgroup/mibII/icmp.c, agent/mibgroup/mibII/kernel_linux.*.
335+ - CVE-2014-2284
336+ * SECURITY UPDATE: denial of service in perl trap handler
337+ - debian/patches/CVE-2014-2285.patch: handle empty community string in
338+ perl/TrapReceiver/TrapReceiver.xs.
339+ - CVE-2014-2285
340+
341+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 08 Apr 2014 08:17:14 -0400
342+
343+net-snmp (5.7.2~dfsg-8.1ubuntu2) trusty; urgency=medium
344+
345+ * Add 00upstream-btrfs.patch: Add btrfs support to hrFSTable. Cherrypicked
346+ from upstream, by way of Nafallo Bjälevik. Thanks! (LP: #1289503)
347+
348+ -- Martin Pitt <martin.pitt@ubuntu.com> Wed, 12 Mar 2014 13:24:18 +0100
349+
350+net-snmp (5.7.2~dfsg-8.1ubuntu1) trusty; urgency=low
351+
352+ * Resynchronise with Debian. Remaining changes:
353+ - Add apport hook.
354+ - Avoid installing links in rc[06].d.
355+
356+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 29 Oct 2013 06:29:46 -0700
357+
358 net-snmp (5.7.2~dfsg-8.1) unstable; urgency=low
359
360 * Non-maintainer upload.
361@@ -367,6 +684,25 @@ net-snmp (5.7.2~dfsg-8.1) unstable; urgency=low
362
363 -- Laurent Bigonville <bigon@debian.org> Sat, 13 Jul 2013 17:13:09 +0200
364
365+net-snmp (5.7.2~dfsg-8ubuntu2) trusty; urgency=low
366+
367+ * Rebuild for Perl 5.18.
368+
369+ -- Colin Watson <cjwatson@ubuntu.com> Mon, 21 Oct 2013 12:30:05 +0100
370+
371+net-snmp (5.7.2~dfsg-8ubuntu1) saucy; urgency=low
372+
373+ * Merge from Debian unstable (LP: #1200516). Remaining changes:
374+ + Add apport hook (LP: #533603):
375+ - debian/source.apport: apport hook
376+ - debian/control: Build-depends on dh-apport.
377+ - debian/rules:
378+ + Add --with apport.
379+ + override_dh_apport to install hook on snmpd package only.
380+ * Call dh_installinit correctly to avoid installing links in rc[06].d
381+
382+ -- Yolanda Robla <yolanda.robla@canonical.com> Fri, 12 Jul 2013 09:47:12 +0200
383+
384 net-snmp (5.7.2~dfsg-8) unstable; urgency=low
385
386 * add libsnmp-perl.preinst to deal with empty directory by libsnmp15
387@@ -415,6 +751,18 @@ net-snmp (5.7.2~dfsg-5) unstable; urgency=low
388
389 -- Hideki Yamane <henrich@debian.org> Sun, 19 May 2013 23:09:52 +0900
390
391+net-snmp (5.7.2~dfsg-4ubuntu1) saucy; urgency=low
392+
393+ * Merge from Debian unstable. Remaining changes:
394+ - debian/rules: Don't stop service in runlevels 0 and 6.
395+ - debian/snmpd.init: LSBify the init script.
396+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
397+ by snmp user before install/uninstall.
398+ - Add apport hook.
399+ * debian/patches/ubuntu-fix-lp-587828.patch: Drop. Fixed upstream.
400+
401+ -- Andres Rodriguez <andreserl@ubuntu.com> Thu, 16 May 2013 21:01:27 -0400
402+
403 net-snmp (5.7.2~dfsg-4) unstable; urgency=low
404
405 * debian/snmpd.{init,default,postinst}
406@@ -595,6 +943,20 @@ net-snmp (5.7.2~dfsg-1~0.1) experimental; urgency=low
407
408 -- Hideki Yamane <henrich@debian.org> Sun, 27 Jan 2013 11:57:29 +0900
409
410+net-snmp (5.4.3~dfsg-2.7ubuntu1) raring; urgency=low
411+
412+ * Merge from Debian unstable. Remaining changes:
413+ - debian/rules: Don't stop service in runlevels 0 and 6.
414+ - debian/snmpd.init: LSBify the init script.
415+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
416+ by snmp user before install/uninstall.
417+ - Add apport hook.
418+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
419+ arches
420+ - debian/{control,rules}: Use dh_python2
421+
422+ -- Logan Rosen <logatronico@gmail.com> Tue, 04 Dec 2012 16:57:00 -0500
423+
424 net-snmp (5.4.3~dfsg-2.7) unstable; urgency=low
425
426 * Non-maintainer upload.
427@@ -611,6 +973,35 @@ net-snmp (5.4.3~dfsg-2.6) unstable; urgency=low
428
429 -- David Prévot <taffit@debian.org> Sun, 18 Nov 2012 09:24:30 -0400
430
431+net-snmp (5.4.3~dfsg-2.5ubuntu1) quantal; urgency=low
432+
433+ * Merge from Debian unstable. Remaining changes:
434+ - debian/rules: Don't stop service in runlevels 0 and 6.
435+ - debian/snmpd.init: LSBify the init script.
436+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
437+ by snmp user before install/uninstall.
438+ - Add apport hook.
439+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
440+ arches
441+ - debian/{control,rules}: Use dh_python2
442+ * Dropped changes:
443+ - debian/patches/50_use_bash.patch: Patch wasn't actually being
444+ applied, and upstream apparently fixed this in 5.4.2.
445+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Patch wasn't actually
446+ being applied, and fix is included in 56_manpage.patch.
447+ - debian/snmpd.postinst: Source debconf before doing work: included in
448+ debian package now.
449+ - debian/patches/99-fix-ubuntu-div0.patch: wasn't applied.
450+ - debian/patches/CVE-2008-6123.*: wasn't applied.
451+ - debian/patches/CVE-2012-2141.patch: use debian's patch.
452+ - debian/README.Debian-source: this change is irrelevant since we
453+ use the debian tarball as-is.
454+ - debian/rules: removed misc irrelevant and undocumented changes.
455+ - debian/snmpd.postinst: no longer need to remove shutdown and reboot
456+ links since this is from Maverick-era.
457+
458+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 20 Jun 2012 09:45:11 -0400
459+
460 net-snmp (5.4.3~dfsg-2.5) unstable; urgency=medium
461
462 * Non-maintainer upload by the Security Team.
463@@ -626,6 +1017,34 @@ net-snmp (5.4.3~dfsg-2.5) unstable; urgency=medium
464
465 -- Luk Claes <luk@debian.org> Sun, 27 May 2012 17:22:01 +0200
466
467+net-snmp (5.4.3~dfsg-2.4ubuntu2) quantal; urgency=low
468+
469+ * SECURITY UPDATE: denial of service via SNMP GET with non-existent
470+ extension table entry
471+ - debian/patches/CVE-2012-2141.patch: validate line_idx in
472+ agent/mibgroup/agent/extend.c.
473+ - CVE-2012-2141
474+
475+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 22 May 2012 16:30:48 -0400
476+
477+net-snmp (5.4.3~dfsg-2.4ubuntu1) precise; urgency=low
478+
479+ * Merge from Debian testing. Remaining changes:
480+ - net-snmp-config: Use bash.
481+ - Removed multiuser option when calling update-rc.d.
482+ - debian/snmpd.init: LSBify the init script.
483+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in
484+ snmpcmd.1.
485+ - debian/snmpd.postinst: Source debconf before doing work.
486+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
487+ by snmp user before install/uninstall.
488+ - Add apport hook.
489+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
490+ arches
491+ - debian/rules: Use dh_python2
492+
493+ -- Chuck Short <zulcss@ubuntu.com> Mon, 23 Jan 2012 09:44:25 -0500
494+
495 net-snmp (5.4.3~dfsg-2.4) unstable; urgency=low
496
497 * Non-maintainer upload.
498@@ -639,6 +1058,35 @@ net-snmp (5.4.3~dfsg-2.4) unstable; urgency=low
499
500 -- Christian Perrier <bubulle@debian.org> Mon, 19 Dec 2011 07:34:31 +0100
501
502+net-snmp (5.4.3~dfsg-2.3ubuntu3) precise; urgency=low
503+
504+ * Build using dh_python2.
505+
506+ -- Matthias Klose <doko@ubuntu.com> Wed, 14 Dec 2011 15:48:05 +0100
507+
508+net-snmp (5.4.3~dfsg-2.3ubuntu2) precise; urgency=low
509+
510+ * Rebuild for Perl 5.14.
511+
512+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 15 Nov 2011 20:49:15 +0000
513+
514+net-snmp (5.4.3~dfsg-2.3ubuntu1) precise; urgency=low
515+
516+ * Merge from debian unstable. Remaining changes:
517+ - net-snmp-config: Use bash.
518+ - Removed multiuser option when calling update-rc.d.
519+ - debian/snmpd.init: LSBify the init script.
520+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in
521+ snmpcmd.1.
522+ - debian/snmpd.postinst: Source debconf before doing work.
523+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
524+ by snmp user before install/uninstall.
525+ - Add apport hook.
526+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
527+ arches.
528+
529+ -- Chuck Short <zulcss@ubuntu.com> Sat, 27 Aug 2011 18:10:55 +0000
530+
531 net-snmp (5.4.3~dfsg-2.3) unstable; urgency=low
532
533 * Non-maintainer upload.
534@@ -648,6 +1096,23 @@ net-snmp (5.4.3~dfsg-2.3) unstable; urgency=low
535
536 -- Stephen Gran <sgran@debian.org> Sat, 27 Aug 2011 09:10:09 +0000
537
538+net-snmp (5.4.3~dfsg-2.2ubuntu1) oneiric; urgency=low
539+
540+ * Resynchronise with Debian (LP: #780149). Remaining changes:
541+ - net-snmp-config: Use bash.
542+ - Removed multiuser option when calling update-rc.d.
543+ - debian/snmpd.init: LSBify the init script.
544+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in
545+ snmpcmd.1.
546+ - debian/snmpd.postinst: Source debconf before doing work.
547+ - debian/snmp.preinst, debian/snmp.prerm: Kill any/all processes owned
548+ by snmp user before install/uninstall.
549+ - Add apport hook.
550+ - debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit
551+ arches.
552+
553+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 10 May 2011 06:14:05 +0100
554+
555 net-snmp (5.4.3~dfsg-2.2) unstable; urgency=high
556
557 * Non-maintainer upload.
558@@ -672,6 +1137,35 @@ net-snmp (5.4.3~dfsg-2.1) unstable; urgency=high
559
560 -- Cyril Brulebois <kibi@debian.org> Sat, 07 May 2011 12:14:26 +0200
561
562+net-snmp (5.4.3~dfsg-2ubuntu2) oneiric; urgency=low
563+
564+ * Rebuild for Perl 5.12.
565+
566+ -- Colin Watson <cjwatson@ubuntu.com> Sat, 07 May 2011 23:29:06 +0100
567+
568+net-snmp (5.4.3~dfsg-2ubuntu1) natty; urgency=low
569+
570+ * Merge from debian unstable. Remaining changes:
571+ - Set Ubuntu maintainer address.
572+ - net-snmp-config: Use bash (LP: #104738)
573+ - Removed multiuser option when calling update-rc.d (LP: #254261)
574+ - debian/snmpd.init: LSBify the init script.
575+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcmd.1
576+ (LP: #250459)
577+ - debian/snmpd.postinst: source debconf before doing work. (LP: #589056)
578+ - debian/snmp.preinst, debian/snmp.prerm: kill any/all processes owned by
579+ snmp user before install/uninstall (LP: #573391)
580+ - Add apport hook (LP: #533603):
581+ - debian/control: Build-depends on dh-apport.
582+ - debian/rules:
583+ + Add --with apport.
584+ + override_dh_apport to install hook on snmpd package only.
585+ - debian/patches/ubntu-fix-lp-58728.patch: Fix row creation for 64bit
586+ arches. (LP: #587828)
587+ - Fix build failures with ld --no-add-needed.
588+
589+ -- Chuck Short <zulcss@ubuntu.com> Thu, 06 Jan 2011 00:35:28 +0000
590+
591 net-snmp (5.4.3~dfsg-2) unstable; urgency=high
592
593 * Add libperl-dev to libsnmp-dev dependencies (Closes: #608794)
594@@ -681,6 +1175,55 @@ net-snmp (5.4.3~dfsg-2) unstable; urgency=high
595
596 -- Jochen Friedrich <jochen@scram.de> Wed, 05 Jan 2011 13:03:32 +0100
597
598+net-snmp (5.4.3~dfsg-1ubuntu5) natty; urgency=low
599+
600+ * Fix build failure with ld --no-add-needed.
601+
602+ -- Matthias Klose <doko@ubuntu.com> Fri, 03 Dec 2010 23:45:33 +0000
603+
604+net-snmp (5.4.3~dfsg-1ubuntu4) natty; urgency=low
605+
606+ * Rebuild to add support for python 2.7.
607+
608+ -- Matthias Klose <doko@ubuntu.com> Fri, 03 Dec 2010 00:05:05 +0000
609+
610+net-snmp (5.4.3~dfsg-1ubuntu3) maverick; urgency=low
611+
612+ * debian/patches/ubuntu-fix-lp-587828.patch: Fix row creation for 64bit arches.
613+ (LP: #587828)
614+
615+ -- Chuck Short <zulcss@ubuntu.com> Wed, 25 Aug 2010 10:18:45 -0400
616+
617+net-snmp (5.4.3~dfsg-1ubuntu2) maverick; urgency=low
618+
619+ * No-change rebuild against current debhelper to drop sizable upstream
620+ changelog.
621+
622+ -- Martin Pitt <martin.pitt@ubuntu.com> Mon, 02 Aug 2010 08:34:07 +0200
623+
624+net-snmp (5.4.3~dfsg-1ubuntu1) maverick; urgency=low
625+
626+ * Merge from debian unstable. Remaining changes:
627+ - Set Ubuntu maintainer address.
628+ - net-snmp-config: Use bash. (LP: #104738)
629+ - Removed multiuser option when calling update-rc.d. (LP: #254261)
630+ - debian/snmpd.init: LSBify the init script.
631+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcmd.1
632+ (LP: #250459)
633+ - debian/snmpd.postinst: source debconf before doing work, LP: #589056
634+ - debian/snmp.preinst, debian/snmp.prerm: kill any/all processes owned by
635+ snmp user before install/uninstall, LP: #573391
636+ - Add apport hook (LP: #533603):
637+ - debian/{snmp,snmpd}.apport: Added.
638+ - debian/control: Build-depends on dh-apport.
639+ - debian/rules:
640+ + Add --with apport.
641+ + override_dh_apport to install hook on snmpd package only.
642+ * Dropped patches:
643+ - debian/patches/99-fix-ubuntu-div0.patch: Fix dvision by zero..
644+
645+ -- Chuck Short <zulcss@ubuntu.com> Mon, 28 Jun 2010 14:59:36 -0400
646+
647 net-snmp (5.4.3~dfsg-1) unstable; urgency=low
648
649 * New upstream version (Closes: #559109)
650@@ -738,6 +1281,73 @@ net-snmp (5.4.2.1~dfsg-4) unstable; urgency=low
651
652 -- Jochen Friedrich <jochen@scram.de> Tue, 01 Dec 2009 18:40:38 +0100
653
654+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu4) maverick; urgency=low
655+
656+ * debian/snmpd.postinst: source debconf before doing work, LP: #589056
657+ * debian/snmp.preinst, debian/snmp.prerm: kill any/all processes owned by
658+ snmp user before install/uninstall, LP: #573391
659+
660+ -- Dustin Kirkland <kirkland@ubuntu.com> Tue, 22 Jun 2010 14:04:48 -0500
661+
662+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu3) maverick; urgency=low
663+
664+ * SECURITY UPDATE: access restriction bypass
665+ - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516801
666+ - http://net-snmp.svn.sourceforge.net/viewvc/net-snmp?view=rev&revision=17367
667+ - CVE-2008-6123
668+
669+ -- Corey Wright <undefined@pobox.com> Mon, 31 May 2010 00:00:29 -0500
670+
671+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu2) lucid; urgency=low
672+
673+ * Add apport hook (LP: #533603):
674+ - debian/{snmp,snmpd}.apport: Added.
675+ - debian/control: Build-depends on dh-apport.
676+ - debian/rules:
677+ + Add --with apport.
678+ + override_dh_apport to install hook on snmpd package only.
679+
680+ -- Andres Rodriguez <andreserl@ubuntu.com> Sun, 28 Mar 2010 00:25:13 -0400
681+
682+net-snmp (5.4.2.1~dfsg0ubuntu1-0ubuntu1) lucid; urgency=low
683+
684+ * Repackage upstream tarball to re-add the MIBs: even if they are not
685+ modifiable (which is questionable), this is not a reason to keep them
686+ out of Ubuntu main.
687+ * Revert the changes to prompt about MIB downloads.
688+ * Call dh_installinit correctly to avoid installing links in rc[06].d
689+ * Temporarily re-add postinst snippet to clean up rc[06].d links left by
690+ the previous upload.
691+ * Fix egg name listed in debian/rules, apparently needed to fix another
692+ build failure.
693+
694+ -- Steve Langasek <steve.langasek@ubuntu.com> Sat, 12 Dec 2009 00:05:34 -0800
695+
696+net-snmp (5.4.2.1~dfsg-3ubuntu2) lucid; urgency=low
697+
698+ * Fix FTBFS.
699+
700+ -- Chuck Short <zulcss@ubuntu.com> Thu, 26 Nov 2009 13:20:26 -0500
701+
702+net-snmp (5.4.2.1~dfsg-3ubuntu1) lucid; urgency=low
703+
704+ * Merge from debian testing. Remaining changes:
705+ - Set Ubuntu maintainer address.
706+ - net-snmp-config: Use bash. (LP: #104738)
707+ - Removed multiuser option when calling update-rc.d. (LP: #254261)
708+ - debian/snmpd.init: LSBify the init script.
709+ - debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcmd.1
710+ (LP: #250459)
711+ - debian/patches/99-fix-ubuntu-div0.patch: Fix dvision by zero.
712+ (LP: #426813).
713+ * Dropped patches:
714+ - debian/patches/101-fix-ipalias.patch: Applied upstream.
715+ - debian/patches/99-fix-net-snmp-syslog.patch: Applied upstream.
716+ - debian/patches/99-fix-perl-counter-in-subagent.patch: Applied upstream.
717+ - ebian/patches/103-fix-ubuntu-lmsensors.patch: No longer needed.
718+
719+ -- Chuck Short <zulcss@ubuntu.com> Thu, 26 Nov 2009 01:27:00 +0000
720+
721 net-snmp (5.4.2.1~dfsg-3) unstable; urgency=low
722
723 * Fix typo in NEWS.
724@@ -802,6 +1412,67 @@ net-snmp (5.4.2.1~dfsg-1) unstable; urgency=low
725
726 -- Jochen Friedrich <jochen@scram.de> Mon, 09 Nov 2009 18:29:10 +0100
727
728+net-snmp (5.4.1~dfsg-12ubuntu7) karmic; urgency=low
729+
730+ * debian/patches/99-fix-ubuntu-div0.patch: Fix division by zero.
731+ (LP: #426813).
732+
733+ -- Chuck Short <zulcss@ubuntu.com> Mon, 28 Sep 2009 14:02:16 -0400
734+
735+net-snmp (5.4.1~dfsg-12ubuntu6) karmic; urgency=low
736+
737+ * debian/patches/101-fix-ipalias.patch : Fix flooding syslog -
738+ Syslog fills with hundreds of these errors if you have a network
739+ interface, e.g. eth2, with no IP address, but you have an alias,
740+ e.g. eth2:1, that does have an IP address (and netmask).
741+ (LP: #270713)
742+ * debian/patches/103-fix-ubuntu-lmsensors.patch: Point to the right
743+ place for /etc/sensors3.conf. (LP: #192745)
744+
745+ -- Chuck Short <zulcss@ubuntu.com> Mon, 14 Sep 2009 12:19:41 -0400
746+
747+net-snmp (5.4.1~dfsg-12ubuntu5) karmic; urgency=low
748+
749+ * debian/patches/99-fix-perl-counter-in-subagent.patch: Fix for Counter64 in
750+ perl subagent. (LP: #406171)
751+
752+ -- Chuck Short <zulcss@ubuntu.com> Fri, 04 Sep 2009 12:10:01 -0500
753+
754+net-snmp (5.4.1~dfsg-12ubuntu4) karmic; urgency=low
755+
756+ * debian/patches/99-fix-net-snmp-syslog.patch: Fixes "invalid syslog facility".
757+ (LP: #369577)
758+
759+ -- Chuck Short <zulcss@ubuntu.com> Wed, 24 Jun 2009 14:44:51 -0400
760+
761+net-snmp (5.4.1~dfsg-12ubuntu3) jaunty; urgency=low
762+
763+ * No-change rebuild to fix lpia shared library dependencies.
764+
765+ -- Colin Watson <cjwatson@ubuntu.com> Thu, 19 Mar 2009 13:00:18 +0000
766+
767+net-snmp (5.4.1~dfsg-12ubuntu2) jaunty; urgency=low
768+
769+ * Python 2.6 transition, debian/rules (LP: #338556):
770+ - Include /usr/share/python/python.mk.
771+ - Use py_sitename and py_setup_install_args macros to install all python
772+ stuffs in the right places (/usr/lib/python*/*-packages/) and rebuild.
773+
774+ -- Alessio Treglia <quadrispro@ubuntu.com> Thu, 12 Mar 2009 00:38:57 +0100
775+
776+net-snmp (5.4.1~dfsg-12ubuntu1) jaunty; urgency=low
777+
778+ * Merge from debian unstable, remaining changes:
779+ - Set Ubuntu maintainer address.
780+ - net-snmp-config: Use bash. LP: #104738)
781+ * Removed multiuser option when calling update-rc.d (LP: #254261).
782+ * debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcd.1
783+ (LP: #250459)
784+ * debian/snmp.init: LSBify the snmpd.init script. Add status notification,
785+ based on initial patch by Gary Coady. (LP: #43575)
786+
787+ -- Chuck Short <zulcss@ubuntu.com> Wed, 17 Dec 2008 00:58:14 +0000
788+
789 net-snmp (5.4.1~dfsg-12) unstable; urgency=high
790
791 * Urgency high because of RC bug fix.
792@@ -812,6 +1483,21 @@ net-snmp (5.4.1~dfsg-12) unstable; urgency=high
793
794 -- Jochen Friedrich <jochen@scram.de> Tue, 16 Dec 2008 15:29:28 +0100
795
796+net-snmp (5.4.1~dfsg-11ubuntu1) jaunty; urgency=low
797+
798+ * Merge from debian unstable, remaining changes:
799+ - Set Ubuntu maintainer address.
800+ - net-snmp-config. Use bash (LP: #104738)
801+ * Removed multiuser option when calling update-rc.d (LP: #254261).
802+ * debian/patches/52_fix_snmpcmd_1_typo.patch: Adjust a typo in snmpcd.1
803+ (LP: #250459)
804+ * debian/snmp.init: LSBify the snmpd.init script. Add status notification,
805+ based on inital patch by Gary Coady. (LP: #43575)
806+ * Dropped debian/patches/51_CVE-2008-0960.patch: Use debian's instead.
807+ * Dropped debian/patches/54_fix_registration_error.patch: Use debian's instead.
808+
809+ -- Chuck Short <zulcss@ubuntu.com> Wed, 05 Nov 2008 02:59:05 +0000
810+
811 net-snmp (5.4.1~dfsg-11) unstable; urgency=high
812
813 * This update fixes the following security issue:
814@@ -859,6 +1545,69 @@ net-snmp (5.4.1~dfsg-8) unstable; urgency=low
815
816 -- Jochen Friedrich <jochen@scram.de> Tue, 03 Jun 2008 13:06:57 +0200
817
818+net-snmp (5.4.1~dfsg-7.1ubuntu6) intrepid; urgency=low
819+
820+ * debian/snmpd.init: Fix snmpd script error. (LP: #270961)
821+
822+ -- Chuck Short <zulcss@ubuntu.com> Mon, 22 Sep 2008 14:18:08 -0400
823+
824+net-snmp (5.4.1~dfsg-7.1ubuntu5) intrepid; urgency=low
825+
826+ * debian/snmpd.init: LSBify the snmpd.init script. And add status
827+ notification, based on inital patch by Gary Coady. (LP: #43575)
828+ * debian/patches/54_fix_registration_error.patch: Surpresses annoying
829+ registrations in startup. (LP: #200614)
830+
831+ -- Chuck Short <zulcss@ubuntu.com> Fri, 12 Sep 2008 13:21:40 -0400
832+
833+net-snmp (5.4.1~dfsg-7.1ubuntu4) intrepid; urgency=low
834+
835+ * Fix lsb headers in init script: stop in single user mode
836+ (LP: #254261).
837+
838+ -- Mathias Gug <mathiaz@ubuntu.com> Thu, 21 Aug 2008 23:07:59 -0400
839+
840+net-snmp (5.4.1~dfsg-7.1ubuntu3) intrepid; urgency=low
841+
842+ [ Salvatore Palma ]
843+ * Add 52_fix_snmpcmd_1_typo.patch patch to adjust a typo in
844+ snmpcmd.1 (LP: #250459).
845+
846+ [ Mathias Gug ]
847+ * Remove multiuser option when calling update-rc.d. (LP: #254261).
848+
849+ -- Mathias Gug <mathiaz@ubuntu.com> Tue, 12 Aug 2008 23:03:05 -0400
850+
851+net-snmp (5.4.1~dfsg-7.1ubuntu2) intrepid; urgency=low
852+
853+ * SECURITY UPDATE: HMAC authentication spoofing.
854+ * debian/patches/51_CVE-2008-0960.patch: fixes HMAC authentication spoofing.
855+ * debian/patches/52_use_right_config_file.patch: Use the right configuration
856+ file for lmsensors. (LP: #192745)
857+
858+ -- Chuck Short <zulcss@ubuntu.com> Mon, 16 Jun 2008 15:47:18 +0000
859+
860+net-snmp (5.4.1~dfsg-7.1ubuntu1) intrepid; urgency=low
861+
862+ * Merge from debian unstable, remaining changes:
863+ - Set Ubuntu maintainer address.
864+ - net-snmp-config: Use bash. LP: #104738.
865+ - Add missing Replaces: libsnmp9-dev (<< 5.4~dfsg) to
866+ libsnmp-base to avoid file confict on dapper->hardy upgrades.
867+ (LP: #203610)
868+
869+ -- Chuck Short <zulcss@ubuntu.com> Tue, 27 May 2008 13:06:56 -0500
870+
871+net-snmp (5.4.1~dfsg-7.1) unstable; urgency=high
872+
873+ * Non-maintainer upload by the Security Team.
874+ * Fix buffer overflow in the python and perl module (__snprint_value
875+ function)that can be exploited via large OCTETSTRING in an
876+ attribute value pair (AVP) leading to arbitrary code
877+ execution (CVE-2008-2292; Closes: #482333).
878+
879+ -- Nico Golde <nion@debian.org> Sat, 24 May 2008 13:12:16 +0200
880+
881 net-snmp (5.4.1~dfsg-7) unstable; urgency=low
882
883 * Add some more Conflicts: and Replaces: magic to allow moving
884@@ -894,6 +1643,41 @@ net-snmp (5.4.1~dfsg-5) unstable; urgency=low
885
886 -- Jochen Friedrich <jochen@scram.de> Fri, 28 Dec 2007 12:43:21 +0100
887
888+net-snmp (5.4.1~dfsg-4ubuntu4) hardy; urgency=low
889+
890+ * Add missing Replaces: libsnmp9-dev (<< 5.4~dfsg) to
891+ libsnmp-base to avoid file confict on dapper->hardy upgrades
892+ (LP: #203610)
893+
894+ -- Michael Vogt <michael.vogt@ubuntu.com> Tue, 18 Mar 2008 17:47:13 +0100
895+
896+net-snmp (5.4.1~dfsg-4ubuntu3) hardy; urgency=low
897+
898+ * Rebuild with recent python-central.
899+ * Set Ubuntu maintainer address.
900+
901+ -- Matthias Klose <doko@ubuntu.com> Mon, 10 Mar 2008 12:46:06 +0000
902+
903+net-snmp (5.4.1~dfsg-4ubuntu2) hardy; urgency=low
904+
905+ * net-snmp-config: Use bash. LP: #104738.
906+
907+ -- Matthias Klose <doko@ubuntu.com> Wed, 06 Feb 2008 14:45:12 +0000
908+
909+net-snmp (5.4.1~dfsg-4ubuntu1) hardy; urgency=low
910+
911+ * Merge from debian unstable.
912+ * Remaining Ubuntu changes:
913+ - Remove stop links from rc0 and rc6
914+ - Munge Maintainer field as per spec.
915+ * Ubuntu changes dropped:
916+ - Symlink common files between the packages, CDBS ought to handle that
917+ for us automatically.
918+ * The latest Debian changes has dropped history from the changelog. Slot in
919+ the Ubuntu changes as best I can.
920+
921+ -- Steve Kowalik <stevenk@ubuntu.com> Sat, 08 Dec 2007 14:59:50 +1100
922+
923 net-snmp (5.4.1~dfsg-4) unstable; urgency=low
924
925 * Do it right this time.
926@@ -981,6 +1765,30 @@ net-snmp (5.4~dfsg-1) experimental; urgency=low
927
928 -- Jochen Friedrich <jochen@scram.de> Fri, 13 Apr 2007 16:16:02 +0200
929
930+net-snmp (5.3.1-6ubuntu2) gutsy; urgency=low
931+
932+ * Do not install the upstream changelog in libsnmp10 and libsnmp-base.
933+ * Symlink files common in libsnmp10 and libsnmp-base.
934+
935+ -- Matthias Klose <doko@ubuntu.com> Fri, 05 Oct 2007 14:55:58 +0200
936+
937+net-snmp (5.3.1-6ubuntu1) gutsy; urgency=low
938+
939+ * Merge from Debian unstable.
940+ * Remaining Ubuntu changes:
941+ - Remove stop links from rc0 and rc6
942+ - Munge Maintainer field as per spec.
943+
944+ -- Steve Kowalik <stevenk@ubuntu.com> Wed, 23 May 2007 08:58:46 +1000
945+
946+net-snmp (5.3.1-5ubuntu1) gutsy; urgency=low
947+
948+ * Merge from Debian unstable.
949+ * Remaining Ubuntu changes:
950+ - Remove stop links from rc0 and rc6
951+ * Munge Maintainer field as per spec.
952+
953+ -- Steve Kowalik <stevenk@ubuntu.com> Thu, 10 May 2007 22:20:23 +1000
954
955 net-snmp (5.3.1-3) unstable; urgency=low
956
957@@ -1037,6 +1845,19 @@ net-snmp (5.3.1-1) experimental; urgency=low
958
959 -- Jochen Friedrich <jochen@scram.de> Wed, 26 Jul 2006 12:08:46 +0200
960
961+net-snmp (5.2.3-4ubuntu1) feisty; urgency=low
962+
963+ * Merge from debian unstable, remaining changes:
964+ - remove stop links from rc0 and rc6
965+
966+ -- Scott James Remnant <scott@ubuntu.com> Tue, 28 Nov 2006 12:29:34 +0000
967+
968+net-snmp (5.2.2-5ubuntu1) edgy; urgency=low
969+
970+ * Remove stop script symlinks from rc0 and rc6.
971+
972+ -- Scott James Remnant <scott@ubuntu.com> Fri, 15 Sep 2006 17:32:44 +0100
973+
974 net-snmp (5.2.2-4) unstable; urgency=low
975
976 * Add French translation. Thanks to Thomas Huriaux
977diff --git a/debian/control b/debian/control
978index 02c87ae..523fab1 100644
979--- a/debian/control
980+++ b/debian/control
981@@ -1,7 +1,8 @@
982 Source: net-snmp
983 Section: net
984 Priority: optional
985-Maintainer: Net-SNMP Packaging Team <pkg-net-snmp-devel@lists.alioth.debian.org>
986+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
987+XSBC-Original-Maintainer: Net-SNMP Packaging Team <pkg-net-snmp-devel@lists.alioth.debian.org>
988 Uploaders: Craig Small <csmall@debian.org>,
989 Thomas Anders <tanders@users.sourceforge.net>,
990 Noah Meyerhans <noahm@debian.org>
991@@ -12,8 +13,8 @@ Build-Depends: debhelper-compat (= 12),
992 pkg-config [kfreebsd-i386 kfreebsd-amd64],
993 libbsd-dev [kfreebsd-i386 kfreebsd-amd64],
994 libkvm-dev [kfreebsd-i386 kfreebsd-amd64],
995- libsensors-dev [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64],
996- default-libmysqlclient-dev, libpci-dev
997+ libsensors4-dev [!hurd-i386 !kfreebsd-i386 !kfreebsd-amd64],
998+ default-libmysqlclient-dev, libpci-dev, dh-apport
999 Build-Conflicts: libsnmp-dev
1000 Standards-Version: 4.4.1
1001 Vcs-Git: https://salsa.debian.org/debian/net-snmp.git
1002diff --git a/debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch b/debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch
1003new file mode 100644
1004index 0000000..2469c49
1005--- /dev/null
1006+++ b/debian/patches/Link-libnetsnmptrapd-against-MYSQL_LIBS.patch
1007@@ -0,0 +1,32 @@
1008+From 9432f629e66e4f9500f6335eab3ad427f84523b2 Mon Sep 17 00:00:00 2001
1009+From: Adam Williamson <awilliam@redhat.com>
1010+Date: Thu, 20 Jul 2017 10:31:47 -0700
1011+Subject: [PATCH] Link libnetsnmptrapd against MYSQL_LIBS
1012+
1013+When building with MySQL (MariaDB) support, this library must
1014+be linked against the MySQL client library, or else it will
1015+have unresolved symbols.
1016+
1017+Origin: https://bugzilla.redhat.com/attachment.cgi?id=1301954
1018+Bug: https://sourceforge.net/p/net-snmp/bugs/2792/
1019+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886221
1020+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/net-snmp/+bug/1814254
1021+Reviewed By: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
1022+Last-Update: 2019-12-12
1023+---
1024+ apps/Makefile.in | 2 +-
1025+ 1 file changed, 1 insertion(+), 1 deletion(-)
1026+
1027+diff --git a/apps/Makefile.in b/apps/Makefile.in
1028+index 1ea4415..e77d433 100644
1029+--- a/apps/Makefile.in
1030++++ b/apps/Makefile.in
1031+@@ -232,7 +232,7 @@ snmppcap$(EXEEXT): snmppcap.$(OSUFFIX) $(USELIBS)
1032+ $(LINK) ${CFLAGS} -o $@ snmppcap.$(OSUFFIX) ${LDFLAGS} ${LIBS} -lpcap
1033+
1034+ libnetsnmptrapd.$(LIB_EXTENSION)$(LIB_VERSION): $(LLIBTRAPD_OBJS)
1035+- $(LIB_LD_CMD) $@ ${LLIBTRAPD_OBJS} $(MIBLIB) $(USELIBS) $(PERLLDOPTS_FOR_LIBS) $(LDFLAGS)
1036++ $(LIB_LD_CMD) $@ ${LLIBTRAPD_OBJS} $(MIBLIB) $(USELIBS) $(PERLLDOPTS_FOR_LIBS) $(LDFLAGS) $(MYSQL_LIBS)
1037+ $(RANLIB) $@
1038+
1039+ snmpinforminstall:
1040diff --git a/debian/patches/autofs-fix-a-recently-introduced-bug.patch b/debian/patches/autofs-fix-a-recently-introduced-bug.patch
1041new file mode 100644
1042index 0000000..23a55ea
1043--- /dev/null
1044+++ b/debian/patches/autofs-fix-a-recently-introduced-bug.patch
1045@@ -0,0 +1,36 @@
1046+HOST-MIB: Fix a recently introduced bug
1047+
1048+Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries")
1049+
1050+Note: this bug was not introduced by Josef but by me.
1051+
1052+Description: HOST-MIB: Fix a recently introduced bug
1053+Author: Bart Van Assche <bvanassche@acm.org>
1054+Origin: upstream, https://github.com/net-snmp/net-snmp/commit/a0df31c18c
1055+Applied-Upstream: v5.8.rc4-386-ga0df31c18 (drop after v5.8.1.pre1)
1056+Bug: https://sourceforge.net/p/net-snmp/bugs/2968/
1057+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935325
1058+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1835818
1059+Reviewed-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
1060+Last-Update: 2019-12-16
1061+
1062+---
1063+ agent/mibgroup/host/hrh_storage.c | 2 +-
1064+ 1 file changed, 1 insertion(+), 1 deletion(-)
1065+
1066+diff --git a/agent/mibgroup/host/hrh_storage.c b/agent/mibgroup/host/hrh_storage.c
1067+index 6f8ff6c53..c7c53922a 100644
1068+--- a/agent/mibgroup/host/hrh_storage.c
1069++++ b/agent/mibgroup/host/hrh_storage.c
1070+@@ -371,7 +371,7 @@ really_try_next:
1071+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1072+ Check_HR_FileSys_NFS())
1073+ return NULL;
1074+- if (Check_HR_FileSys_AutoFs())
1075++ if (HRFS_entry && Check_HR_FileSys_AutoFs())
1076+ return NULL;
1077+ if (store_idx <= NETSNMP_MEM_TYPE_MAX ) {
1078+ mem = (netsnmp_memory_info*)ptr;
1079+--
1080+2.24.0
1081+
1082diff --git a/debian/patches/autofs-skip-autofs-entries.patch b/debian/patches/autofs-skip-autofs-entries.patch
1083new file mode 100644
1084index 0000000..7f5f258
1085--- /dev/null
1086+++ b/debian/patches/autofs-skip-autofs-entries.patch
1087@@ -0,0 +1,237 @@
1088+HOST-MIB: Skip autofs entries
1089+
1090+Do not call statfs() for autofs entries.
1091+
1092+See also https://sourceforge.net/p/net-snmp/patches/1350/.
1093+See also https://sourceforge.net/p/net-snmp/bugs/2968/.
1094+
1095+[ bvanassche: Made several small edits ]
1096+
1097+Description: HOST-MIB: Skip autofs entries
1098+Author: Josef Ridky <jridky@redhat.com>
1099+Origin: upstream, https://github.com/net-snmp/net-snmp/commit/cf41e6e910
1100+Applied-Upstream: v5.8.rc4-366-gcf41e6e91 (drop after v5.8.1.pre1)
1101+Bug: https://sourceforge.net/p/net-snmp/bugs/2968/
1102+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935325
1103+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1835818
1104+Reviewed-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
1105+Last-Update: 2019-12-16
1106+---
1107+ agent/mibgroup/hardware/fsys/fsys_mntctl.c | 8 ++++++--
1108+ agent/mibgroup/hardware/fsys/fsys_mntent.c | 11 +++++++++++
1109+ agent/mibgroup/hardware/fsys/mnttypes.h | 3 +++
1110+ agent/mibgroup/host/hr_filesys.c | 21 +++++++++++++++++++++
1111+ agent/mibgroup/host/hr_filesys.h | 1 +
1112+ agent/mibgroup/host/hr_storage.c | 5 ++++-
1113+ agent/mibgroup/host/hrh_filesys.c | 6 ++++++
1114+ agent/mibgroup/host/hrh_filesys.h | 1 +
1115+ agent/mibgroup/host/hrh_storage.c | 5 ++++-
1116+ include/net-snmp/agent/hardware/fsys.h | 1 +
1117+ 10 files changed, 58 insertions(+), 4 deletions(-)
1118+
1119+diff --git a/agent/mibgroup/hardware/fsys/fsys_mntctl.c b/agent/mibgroup/hardware/fsys/fsys_mntctl.c
1120+index e7d9a1c5a..782c8edd2 100644
1121+--- a/agent/mibgroup/hardware/fsys/fsys_mntctl.c
1122++++ b/agent/mibgroup/hardware/fsys/fsys_mntctl.c
1123+@@ -43,8 +43,9 @@ _fsys_type( int type)
1124+
1125+ case MNT_NFS:
1126+ case MNT_NFS3:
1127+- case MNT_AUTOFS:
1128+ return NETSNMP_FS_TYPE_NFS;
1129++ case MNT_AUTOFS:
1130++ return NETSNMP_FS_TYPE_AUTOFS;
1131+
1132+ /*
1133+ * The following code covers selected filesystems
1134+@@ -155,12 +156,15 @@ netsnmp_fsys_arch_load( void )
1135+ */
1136+
1137+ /*
1138+- * Optionally skip retrieving statistics for remote mounts
1139++ * Skip retrieving statistics for AUTOFS and optionally for remote
1140++ * mounts.
1141+ */
1142+ if ( (entry->flags & NETSNMP_FS_FLAG_REMOTE) &&
1143+ netsnmp_ds_get_boolean(NETSNMP_DS_APPLICATION_ID,
1144+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES))
1145+ continue;
1146++ if (entry->type == NETSNMP_FS_TYPE_AUTOFS)
1147++ continue;
1148+
1149+ if ( statfs( entry->path, &stat_buf ) < 0 ) {
1150+ snprintf( tmpbuf, sizeof(tmpbuf), "Cannot statfs %s", entry->path );
1151+diff --git a/agent/mibgroup/hardware/fsys/fsys_mntent.c b/agent/mibgroup/hardware/fsys/fsys_mntent.c
1152+index 3cdcea1fb..79e6e4f72 100644
1153+--- a/agent/mibgroup/hardware/fsys/fsys_mntent.c
1154++++ b/agent/mibgroup/hardware/fsys/fsys_mntent.c
1155+@@ -150,6 +150,13 @@ _fsys_type( char *typename )
1156+ !strcmp(typename, MNTTYPE_LOFS))
1157+ return NETSNMP_FS_TYPE_OTHER;
1158+
1159++ /* Detection of AUTOFS.
1160++ * This file system will be ignored by default
1161++ */
1162++ else if (!strcmp(typename, MNTTYPE_AUTOFS))
1163++ return NETSNMP_FS_TYPE_AUTOFS;
1164++
1165++
1166+ /*
1167+ * All other types are silently skipped
1168+ */
1169+@@ -239,6 +246,10 @@ netsnmp_fsys_arch_load( void )
1170+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES))
1171+ continue;
1172+
1173++ /* Skip AUTOFS entries */
1174++ if (entry->type == NETSNMP_FS_TYPE_AUTOFS)
1175++ continue;
1176++
1177+ #ifdef irix6
1178+ if ( NSFS_STATFS( entry->path, &stat_buf, sizeof(struct statfs), 0) < 0 )
1179+ #else
1180+diff --git a/agent/mibgroup/hardware/fsys/mnttypes.h b/agent/mibgroup/hardware/fsys/mnttypes.h
1181+index bb1b40173..53f1cc896 100644
1182+--- a/agent/mibgroup/hardware/fsys/mnttypes.h
1183++++ b/agent/mibgroup/hardware/fsys/mnttypes.h
1184+@@ -165,6 +165,9 @@
1185+ #ifndef MNTTYPE_APP
1186+ #define MNTTYPE_APP "app"
1187+ #endif
1188++#ifndef MNTTYPE_AUTOFS
1189++#define MNTTYPE_AUTOFS "autofs"
1190++#endif
1191+ #ifndef MNTTYPE_DEVPTS
1192+ #define MNTTYPE_DEVPTS "devpts"
1193+ #endif
1194+diff --git a/agent/mibgroup/host/hr_filesys.c b/agent/mibgroup/host/hr_filesys.c
1195+index 56c8b2095..8caeecf4e 100644
1196+--- a/agent/mibgroup/host/hr_filesys.c
1197++++ b/agent/mibgroup/host/hr_filesys.c
1198+@@ -834,6 +834,27 @@ Check_HR_FileSys_NFS (void)
1199+ return 0; /* no NFS file system */
1200+ }
1201+
1202++/* This function checks whether current file system is an AutoFs
1203++ * HRFS_entry must be valid prior to calling this function
1204++ * return 1 if AutoFs, 0 otherwise
1205++ */
1206++int
1207++Check_HR_FileSys_AutoFs(void)
1208++{
1209++#if HAVE_GETFSSTAT
1210++ if (HRFS_entry->HRFS_type != NULL &&
1211++#if defined(MNTTYPE_AUTOFS)
1212++ !strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS)
1213++#else
1214++ !strcmp(HRFS_entry->HRFS_type, "autofs")
1215++#endif
1216++ )
1217++#endif /* HAVE_GETFSSTAT */
1218++ return 1; /* AUTOFS */
1219++
1220++ return 0; /* no AUTOFS */
1221++}
1222++
1223+ void
1224+ End_HR_FileSys(void)
1225+ {
1226+diff --git a/agent/mibgroup/host/hr_filesys.h b/agent/mibgroup/host/hr_filesys.h
1227+index 2f00355f3..36cd7dd08 100644
1228+--- a/agent/mibgroup/host/hr_filesys.h
1229++++ b/agent/mibgroup/host/hr_filesys.h
1230+@@ -10,6 +10,7 @@ extern void Init_HR_FileSys(void);
1231+ extern FindVarMethod var_hrfilesys;
1232+ extern int Get_Next_HR_FileSys(void);
1233+ extern int Check_HR_FileSys_NFS(void);
1234++extern int Check_HR_FileSys_AutoFs(void);
1235+
1236+ extern int Get_FSIndex(char *);
1237+ extern long Get_FSSize(char *); /* Temporary */
1238+diff --git a/agent/mibgroup/host/hr_storage.c b/agent/mibgroup/host/hr_storage.c
1239+index a86898451..6b459ec51 100644
1240+--- a/agent/mibgroup/host/hr_storage.c
1241++++ b/agent/mibgroup/host/hr_storage.c
1242+@@ -544,6 +544,8 @@ really_try_next:
1243+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1244+ Check_HR_FileSys_NFS())
1245+ return NULL; /* or goto try_next; */
1246++ if (Check_HR_FileSys_AutoFs())
1247++ return NULL;
1248+ if (HRFS_statfs(HRFS_entry->HRFS_mount, &stat_buf) < 0) {
1249+ snmp_log_perror(HRFS_entry->HRFS_mount);
1250+ goto try_next;
1251+@@ -683,7 +685,8 @@ Get_Next_HR_Store(void)
1252+ if (HRS_index >= 0) {
1253+ if (!(netsnmp_ds_get_boolean(NETSNMP_DS_APPLICATION_ID,
1254+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1255+- Check_HR_FileSys_NFS())) {
1256++ Check_HR_FileSys_NFS()) &&
1257++ !Check_HR_FileSys_AutoFs()) {
1258+ return HRS_index + NETSNMP_MEM_TYPE_MAX;
1259+ }
1260+ } else {
1261+diff --git a/agent/mibgroup/host/hrh_filesys.c b/agent/mibgroup/host/hrh_filesys.c
1262+index 5ad82b20f..5d2102e24 100644
1263+--- a/agent/mibgroup/host/hrh_filesys.c
1264++++ b/agent/mibgroup/host/hrh_filesys.c
1265+@@ -429,3 +429,9 @@ Check_HR_FileSys_NFS (void)
1266+ {
1267+ return (HRFS_entry->flags & NETSNMP_FS_FLAG_REMOTE) ? 1 : 0;
1268+ }
1269++
1270++int
1271++Check_HR_FileSys_AutoFs (void)
1272++{
1273++ return HRFS_entry->type == NETSNMP_FS_TYPE_AUTOFS;
1274++}
1275+diff --git a/agent/mibgroup/host/hrh_filesys.h b/agent/mibgroup/host/hrh_filesys.h
1276+index 568917e09..c0f5d6e8c 100644
1277+--- a/agent/mibgroup/host/hrh_filesys.h
1278++++ b/agent/mibgroup/host/hrh_filesys.h
1279+@@ -10,6 +10,7 @@ extern void Init_HR_FileSys(void);
1280+ extern FindVarMethod var_hrhfilesys;
1281+ extern int Get_Next_HR_FileSys(void);
1282+ extern int Check_HR_FileSys_NFS(void);
1283++extern int Check_HR_FileSys_AutoFs(void);
1284+
1285+ extern int Get_FSIndex(char *);
1286+ extern long Get_FSSize(char *); /* Temporary */
1287+diff --git a/agent/mibgroup/host/hrh_storage.c b/agent/mibgroup/host/hrh_storage.c
1288+index 810766946..6f8ff6c53 100644
1289+--- a/agent/mibgroup/host/hrh_storage.c
1290++++ b/agent/mibgroup/host/hrh_storage.c
1291+@@ -371,6 +371,8 @@ really_try_next:
1292+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1293+ Check_HR_FileSys_NFS())
1294+ return NULL;
1295++ if (Check_HR_FileSys_AutoFs())
1296++ return NULL;
1297+ if (store_idx <= NETSNMP_MEM_TYPE_MAX ) {
1298+ mem = (netsnmp_memory_info*)ptr;
1299+ }
1300+@@ -508,7 +510,8 @@ Get_Next_HR_Store(void)
1301+ if (HRS_index >= 0) {
1302+ if (!(netsnmp_ds_get_boolean(NETSNMP_DS_APPLICATION_ID,
1303+ NETSNMP_DS_AGENT_SKIPNFSINHOSTRESOURCES) &&
1304+- Check_HR_FileSys_NFS())) {
1305++ Check_HR_FileSys_NFS()) &&
1306++ !Check_HR_FileSys_AutoFs()) {
1307+ return HRS_index + NETSNMP_MEM_TYPE_MAX;
1308+ }
1309+ } else {
1310+diff --git a/include/net-snmp/agent/hardware/fsys.h b/include/net-snmp/agent/hardware/fsys.h
1311+index 3f2b28440..54ab9d806 100644
1312+--- a/include/net-snmp/agent/hardware/fsys.h
1313++++ b/include/net-snmp/agent/hardware/fsys.h
1314+@@ -41,6 +41,7 @@ typedef struct netsnmp_fsys_info_s netsnmp_fsys_info;
1315+ #define NETSNMP_FS_TYPE_SYSFS (4 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)
1316+ #define NETSNMP_FS_TYPE_TMPFS (5 | _NETSNMP_FS_TYPE_LOCAL)
1317+ #define NETSNMP_FS_TYPE_USBFS (6 | _NETSNMP_FS_TYPE_LOCAL)
1318++#define NETSNMP_FS_TYPE_AUTOFS (7 | _NETSNMP_FS_TYPE_LOCAL | _NETSNMP_FS_TYPE_SKIP_BIT)
1319+
1320+ #define NETSNMP_FS_FLAG_ACTIVE 0x01
1321+ #define NETSNMP_FS_FLAG_REMOTE 0x02
1322+--
1323+2.24.0
1324+
1325diff --git a/debian/patches/fix-check-hr-filesys-autofs.patch b/debian/patches/fix-check-hr-filesys-autofs.patch
1326new file mode 100644
1327index 0000000..9751a94
1328--- /dev/null
1329+++ b/debian/patches/fix-check-hr-filesys-autofs.patch
1330@@ -0,0 +1,36 @@
1331+Description: HOST-MIB, hr_filesys: Fix Check_HR_FileSys_AutoFs()
1332+
1333+ On Linux getmntent() is available but getfsstat() not. Hence remove #if
1334+ HAVE_GETFSSTAT from around the HRFS_type check.
1335+
1336+ See also https://sourceforge.net/p/net-snmp/patches/1350/.
1337+ Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries").
1338+Author: Bart Van Assche <bvanassche@acm.org>
1339+Origin: upstream, https://github.com/net-snmp/net-snmp/commit/bcb1a6b8afc444bbcd099a195e08f0b01cbc8f6b
1340+Bug: https://sourceforge.net/p/net-snmp/patches/1350/
1341+Bug-Ubuntu: https://launchpad.net/bugs/1843036
1342+Index: net-snmp-5.7.3+dfsg/agent/mibgroup/host/hr_filesys.c
1343+===================================================================
1344+--- net-snmp-5.7.3+dfsg.orig/agent/mibgroup/host/hr_filesys.c
1345++++ net-snmp-5.7.3+dfsg/agent/mibgroup/host/hr_filesys.c
1346+@@ -846,18 +846,8 @@ Check_HR_FileSys_NFS (void)
1347+ int
1348+ Check_HR_FileSys_AutoFs(void)
1349+ {
1350+-#if HAVE_GETFSSTAT
1351+- if (HRFS_entry->HRFS_type != NULL &&
1352+-#if defined(MNTTYPE_AUTOFS)
1353+- !strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS)
1354+-#else
1355+- !strcmp(HRFS_entry->HRFS_type, "autofs")
1356+-#endif
1357+- )
1358+-#endif /* HAVE_GETFSSTAT */
1359+- return 1; /* AUTOFS */
1360+-
1361+- return 0; /* no AUTOFS */
1362++ return HRFS_entry->HRFS_type &&
1363++ strcmp(HRFS_entry->HRFS_type, MNTTYPE_AUTOFS) == 0;
1364+ }
1365+
1366+ void
1367diff --git a/debian/patches/mysql8-replace-bool.patch b/debian/patches/mysql8-replace-bool.patch
1368new file mode 100644
1369index 0000000..8c66f4a
1370--- /dev/null
1371+++ b/debian/patches/mysql8-replace-bool.patch
1372@@ -0,0 +1,26 @@
1373+apps/snmptrapd_sql: Fix build against MySQL 8
1374+
1375+See also https://sourceforge.net/p/net-snmp/bugs/2922/.
1376+
1377+[bvanassche: changed 'int' into 'char']
1378+
1379+Description: apps/snmptrapd_sql: Fix build against MySQL 8
1380+Author: Andreas Hasenack <ahasenack2@users.sourceforge.net>
1381+Origin: upstream, https://github.com/net-snmp/net-snmp/commit/9f4af8c42d
1382+Bug: https://sourceforge.net/p/net-snmp/bugs/2922/
1383+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1814270
1384+Applied-Upstream: v5.8.rc4-180-g9f4af8c42 (drop after v5.8.1.pre1)
1385+Reviewed-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
1386+Last-Update: 2019-12-16
1387+
1388+--- a/apps/snmptrapd_sql.c
1389++++ b/apps/snmptrapd_sql.c
1390+@@ -194,7 +194,7 @@ typedef struct sql_buf_t {
1391+ * static bind structures, plus 2 static buffers to bind to.
1392+ */
1393+ static MYSQL_BIND _tbind[TBIND_MAX], _vbind[VBIND_MAX];
1394+-static my_bool _no_v3;
1395++static char _no_v3;
1396+
1397+ static void _sql_process_queue(u_int dontcare, void *meeither);
1398+
1399diff --git a/debian/patches/series b/debian/patches/series
1400index 1d0cb11..460f931 100644
1401--- a/debian/patches/series
1402+++ b/debian/patches/series
1403@@ -31,3 +31,8 @@ snmpcmd_1_groff
1404 netsnmp_mib_api_3_groff
1405 snmplib_error_subcontainer
1406 apps_makefile_use_ldflags
1407+Link-libnetsnmptrapd-against-MYSQL_LIBS.patch
1408+mysql8-replace-bool.patch
1409+autofs-skip-autofs-entries.patch
1410+autofs-fix-a-recently-introduced-bug.patch
1411+fix-check-hr-filesys-autofs.patch
1412diff --git a/debian/rules b/debian/rules
1413index 181ad5c..1314ba1 100755
1414--- a/debian/rules
1415+++ b/debian/rules
1416@@ -28,7 +28,7 @@ MIB_MODULES += host
1417 endif
1418
1419 %:
1420- dh $@
1421+ dh $@ --with apport
1422
1423 # The net-snmp Makefiles cannot handle parallel builds
1424 override_dh_auto_build:
1425@@ -86,6 +86,10 @@ override_dh_fixperms-arch:
1426 chmod -x debian/libsnmp-dev/etc/snmp/*.conf
1427 chmod 600 debian/snmpd/etc/snmp/snmp*d.conf
1428
1429+.PHONY: override_dh_apport
1430+override_dh_apport:
1431+ dh_apport -psnmpd
1432+
1433 override_dh_auto_test:
1434 # prevent test since it fails with network configuration under pbuilder/etc.
1435 true
1436diff --git a/debian/source.apport b/debian/source.apport
1437new file mode 100644
1438index 0000000..867fe9e
1439--- /dev/null
1440+++ b/debian/source.apport
1441@@ -0,0 +1,36 @@
1442+#!/usr/bin/python
1443+
1444+'''apport hook for net-snmp
1445+
1446+(c) 2010 Andres Rodriguez
1447+Author: Andres Rodriguez <andreserl@ubuntu.com>
1448+
1449+This program is free software; you can redistribute it and/or modify it
1450+under the terms of the GNU General Public License as published by the
1451+Free Software Foundation; either version 2 of the License, or (at your
1452+option) any later version. See http://www.gnu.org/copyleft/gpl.html for
1453+the full text of the license.
1454+'''
1455+
1456+from apport.hookutils import *
1457+import re
1458+
1459+def add_info(report, ui):
1460+ response = ui.yesno("The contents of your /etc/snmp/snmpd.conf and "
1461+ "your /etc/snmp/snmptrapd.conf files may help "
1462+ "developers diagnose your bug more quickly. "
1463+ "However, it may contain sensitive information. "
1464+ "Do you want to include it in your bug report?")
1465+
1466+ if response == None: # user cancelled
1467+ raise StopIteration
1468+
1469+ elif response == True:
1470+ attach_conffiles(report, 'snmpd')
1471+
1472+ # get version
1473+ report['SNMPVersion'] = root_command_output(['/usr/sbin/snmpd', '-v'])
1474+
1475+ # get syslog stuff
1476+ report['SyslogSnmpd'] = recent_syslog(re.compile('snmpd\['))
1477+ report['SyslogSnmptrapd'] = recent_syslog(re.compile('snmptrapd\['))

Subscribers

People subscribed via source and target branches