Merge ~rafaeldtinoco/ubuntu/+source/libqb:lp1891780-groovy into ubuntu/+source/libqb:ubuntu/devel

Proposed by Rafael David Tinoco
Status: Rejected
Rejected by: Rafael David Tinoco
Proposed branch: ~rafaeldtinoco/ubuntu/+source/libqb:lp1891780-groovy
Merge into: ubuntu/+source/libqb:ubuntu/devel
Diff against target: 54 lines (+17/-3)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/tests/control (+2/-2)
debian/tests/ipc (+6/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Disapprove
Canonical Server Pending
Canonical Server Core Reviewers Pending
Rafael David Tinoco Pending
Review via email: mp+389382@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Fail
"Depends: gcc:i386 but it is not installable"

Ok, sounds fine we don't want/need this for i386 anyway.

Couldn't this instead be just
  force-reset-test libqb/1.0.6-1
in lp:~ubuntu-release/britney/hints-ubuntu and that way avoid the need for tracking and re-merging this later on?

I think this is a perfect match for the section starting with:
"# these packages will continue to build on i386 but may not be cross-testable"

review: Disapprove
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Well better i386 specific and since there is no hope no need to reset, so maybe this instead:
  force-badtest libqb/all/i386

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

There already is this line
  10391 force-badtest libqb/1.0.5-1/i386

Replace it with the one (and placing) suggested above

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I am (was) trying to skip i386 britney changes for i386 badtests as I have been pushed back a few times in adding badtests. Let me try adding badtest for this then.

Unmerged commits

cfd3cfb... by Rafael David Tinoco

update-metadata

527bddc... by Rafael David Tinoco

changelog

88669dc... by Rafael David Tinoco

* d/t/control, d/t/ipc: Disable autopkgtest for i386 architecture.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 6d44fed..cf1c2fe 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+libqb (1.0.6-1ubuntu1) groovy; urgency=medium
7+
8+ * d/t/control, d/t/ipc: Disable autopkgtest for i386 architecture.
9+ (LP: #1891780)
10+
11+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Sun, 16 Aug 2020 00:59:31 +0000
12+
13 libqb (1.0.6-1) unstable; urgency=medium
14
15 [ Ferenc Wágner ]
16diff --git a/debian/control b/debian/control
17index 99284cd..0d3e48c 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,6 +1,7 @@
21 Source: libqb
22 Priority: optional
23-Maintainer: Debian HA Maintainers <debian-ha-maintainers@alioth-lists.debian.net>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Debian HA Maintainers <debian-ha-maintainers@alioth-lists.debian.net>
26 Uploaders:
27 Ferenc Wágner <wferi@debian.org>,
28 Adrian Vondendriesch <adrian.vondendriesch@credativ.de>
29diff --git a/debian/tests/control b/debian/tests/control
30index 35c6ed9..f78a181 100644
31--- a/debian/tests/control
32+++ b/debian/tests/control
33@@ -1,3 +1,3 @@
34-Depends: libqb-dev, gcc, libc6-dev, pkg-config
35+Depends: libqb-dev, gcc [amd64 arm64 armhf ppc64el s390x], libc6-dev, pkg-config
36 Tests: ipc
37-Restrictions: allow-stderr
38+Restrictions: allow-stderr, skippable
39diff --git a/debian/tests/ipc b/debian/tests/ipc
40index e24cf41..7804148 100755
41--- a/debian/tests/ipc
42+++ b/debian/tests/ipc
43@@ -1,5 +1,11 @@
44 #!/bin/sh -ex
45
46+[ `dpkg-architecture -qDEB_TARGET_ARCH` == "i386" ] && {
47+ # https://bugs.launchpad.net/bugs/1891780
48+ echo "test disabled for this architecture"
49+ exit 77
50+}
51+
52 cd examples
53 # the os_base.h in-tree header includes inttypes.h for the examples
54 ln -sf /usr/include/inttypes.h os_base.h # -f to enable repeated runs

Subscribers

People subscribed via source and target branches