Merge ~rafaeldtinoco/ubuntu/+source/kmod:lp1864992-devel into ubuntu/+source/kmod:ubuntu/focal-devel

Proposed by Rafael David Tinoco
Status: Merged
Merge reported by: Rafael David Tinoco
Merged at revision: d0b403aa8fab6d80cc765ce4263350b37027eb78
Proposed branch: ~rafaeldtinoco/ubuntu/+source/kmod:lp1864992-devel
Merge into: ubuntu/+source/kmod:ubuntu/focal-devel
Diff against target: 58 lines (+8/-26)
3 files modified
debian/changelog (+8/-0)
debian/patches/series (+0/-1)
dev/null (+0/-25)
Reviewer Review Type Date Requested Status
Rafael David Tinoco (community) Approve
Christian Ehrhardt  (community) Approve
Thadeu Lima de Souza Cascardo Pending
Review via email: mp+380577@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

This is wrong.. latest version is:

27-1ubuntu1

but usd-importer is stuck at

26+20191223-1ubuntu1

Please disconsider versioning for now, I'll fix that.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I'm +1 going forward for 20.04, I'm torn for the SRU cases (will mention on those MPs) but going forward I think the change LGTM.

review: Approve
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Thanks for reviewing this!

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

Because of the git-ubuntu issue I haven't pushed this to usd-import.. only uploaded.
Lets see if this new upload makes git-ubuntu not to crash when trying to import it.
Thanks again.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 9a1a47a..6cefc94 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+kmod (26+20191223-1ubuntu2) focal; urgency=medium
7+
8+ * d/p/verbose_missing_bin: drop this patch to avoid spurious missing
9+ file messages when running depmod -a for the first time in recent
10+ kernels (>= 5.3.x) (LP: #1864992)
11+
12+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Wed, 11 Mar 2020 19:21:09 +0000
13+
14 kmod (26+20191223-1ubuntu1) focal; urgency=low
15
16 * Merge from Debian unstable. Remaining changes:
17diff --git a/debian/patches/series b/debian/patches/series
18index a0f32d0..dc7382c 100644
19--- a/debian/patches/series
20+++ b/debian/patches/series
21@@ -1,6 +1,5 @@
22
23 # fixes to be pushed upstream
24-verbose_missing_bin
25
26 # features to be pushed upstream
27
28diff --git a/debian/patches/verbose_missing_bin b/debian/patches/verbose_missing_bin
29deleted file mode 100644
30index f2aec1f..0000000
31--- a/debian/patches/verbose_missing_bin
32+++ /dev/null
33@@ -1,25 +0,0 @@
34-Description: Report an error when some .bin files do not exist
35-Author: Marco d'Itri <md@linux.it>
36-Bug-Debian: http://bugs.debian.org/684901
37----
38-
39---- a/libkmod/libkmod.c
40-+++ b/libkmod/libkmod.c
41-@@ -503,7 +503,7 @@ static char *lookup_builtin_file(struct
42-
43- idx = index_file_open(fn);
44- if (idx == NULL) {
45-- DBG(ctx, "could not open builtin file '%s'\n", fn);
46-+ ERR(ctx, "could not open builtin file '%s'\n", fn);
47- return NULL;
48- }
49-
50-@@ -575,7 +575,7 @@ char *kmod_search_moddep(struct kmod_ctx
51-
52- idx = index_file_open(fn);
53- if (idx == NULL) {
54-- DBG(ctx, "could not open moddep file '%s'\n", fn);
55-+ ERR(ctx, "could not open moddep file '%s'\n", fn);
56- return NULL;
57- }
58-

Subscribers

People subscribed via source and target branches