Merge ~rafaeldtinoco/ubuntu/+source/iproute2:lp1831775-cosmic-sru-iproute2 into ubuntu/+source/iproute2:ubuntu/cosmic-devel
Proposed by
Rafael David Tinoco
Status: | Superseded |
---|---|
Proposed branch: | ~rafaeldtinoco/ubuntu/+source/iproute2:lp1831775-cosmic-sru-iproute2 |
Merge into: | ubuntu/+source/iproute2:ubuntu/cosmic-devel |
Diff against target: |
161 lines (+139/-0) 3 files modified
debian/changelog (+8/-0) debian/patches/series (+2/-0) debian/patches/ss-review-ssfilter.patch (+129/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Canonical Server Core Reviewers | Pending | ||
Canonical Server | Pending | ||
Andreas Hasenack | Pending | ||
Review via email: mp+368408@code.launchpad.net |
This proposal supersedes a proposal from 2019-06-05.
Description of the change
Cosmic Fix for issue: https:/
To post a comment you must log in.
Thanks, some comments inline, and below.
For SRUs, the merge target should always be ubuntu/ <release> -devel.
Can you elaborate a bit more on the test case you added to the bug? Like, what to expect in the broken and in the good cases. Ideally it should be as simple as just copying and pasting something in the command line, but it's fine if it needs some setting up. For example, "create a connection from A to B, note the IPs used, and use the IPs in the following command."
I saw you added some test results further down in the bug, but for the SRU template, it's best if all that's needed to verify the bug is fixed is in the "opening salvo".
In "regression potential", you say " * ss interpreter (bison powered) could be broken". What does that mean? Why do you think it could be broken? These are questions the SRU team would probably ask. "ip" is used all over the place, and it's good to detail what are your thoughts on possible regressions.