* Changelog: - [√] old content and logical tag match as expected - [√] changelog entry correct version and targeted codename - [√] changelog entries correct - [√] update-maintainer has been run * Actual changes: - [ ] no upstream changes to consider - [√] no further upstream version to consider - [√] debian changes look safe * Old Delta: - [-] dropped changes are ok to be dropped - [-] nothing else to drop - [-] changes forwarded upstream/debian (if appropriate) * New Delta: - [-] no new patches added - [√] patches match what was proposed upstream - [√] patches correctly included in debian/patches/series - [√] patches have correct DEP3 metadata * Build/Test: - [ ] build is ok - [ ] verified PPA package installs/uninstalls - [ ] autopkgtest against the PPA package passes - [ ] sanity checks test fine I didn't take time to run the tests or try the installation, but can do so tomorrow if desired. I assume if there were test issues, they'll show up in the autopkgtest runs. * Code review on patches: - ubuntu/lp1895728-669f13b5-Fix-bootstrap-Change-condition-to-add-stonith-sbd-re.patch + Code changes looks correct & safe + Fix Origin: url is incomplete (needs SHA appended) + "bsc#1166967" sounds like a bug tracker ticket but I could not find a public bug system with that identifier. If there is one, it would be useful to link to it via a "Bug: ..." DEP3 tag. From the upstream commit entry there's a link to the pull request which has some discussion, so lacking access to the 'bsc', you could add "Bug: https://github.com/ClusterLabs/crmsh/pull/545". - ubuntu/lp1895728-997f62d6-Fix-hb_report-disable-dump-all-tasks-stack-into-dmes.patch + Fix Origin: url is incomplete (needs SHA appended) + Add Bug: https://github.com/ClusterLabs/crmsh/pull/486 (or bsc#1158060) + It looks like the important piece of this patch is dropping the "echo t > /proc/sysrq-trigger" line. However it is also adding dump_D_process() to add some process state info; dump_D_process() is running a few bash commands which feels a bit janky. Since this is not an SRU I think it's good enough, but if it was an SRU I'd suggest dropping dump_D_process() and carrying only the actual fix. - ubuntu/lp1895728-cce28254-Fix-crmsh.spec-using-mktemp-to-create-tmp-file-bsc-1.patch + LGTM. Personally I'd use $() rather than `` but this is technically correct and using mktemp is a good improvement. + Fix Origin: url is incomplete (needs SHA appended) + Add Bug: https://github.com/ClusterLabs/crmsh/pull/502 (or bsc#1154163) - ubuntu/lp1895728-e098387e-Fix-bootstrap-use-csync2-f-option-correctly-bsc-1166.patch + Fix Origin: url is incomplete (needs SHA appended) + Add Bug: https://github.com/ClusterLabs/crmsh/pull/542 (or bsc#1166684) + Code changes look good per the pull request, although I wonder if csync2_update() should throw an exception if the second `csync2 -rxv` fails, but the warning is at least an improvement over the prior code. + Just a nitpick but I notice this patch uses "synced" in one message and "sync'd" in another. - ubuntu/lp1895728-ca1f0a7f-Fix-ui_resource-refresh-Tab-should-complete-resource.patch + Code changes looks correct & safe + Fix Origin: url is incomplete (needs SHA appended) + Add Bug: https://github.com/ClusterLabs/crmsh/pull/561 (or bsc#1167220) - ubuntu/lp1895728-78ce77e4-Low-hb_report-Fix-collecting-of-binary-data-bsc-1166.patch + Fix Origin: url is incomplete (needs SHA appended) + Add Bug: https://github.com/ClusterLabs/crmsh/pull/610 (or where ever bsc#1166962 is) + There are a couple potential issues I spot with this patch (see inline comments), I think it'd be worth your doublecheck. The Origin and Bug issues are the main things needing fixed, the others I flag mainly just FYI - would be nice to see fixed but not required or expected.