Merge lp:~rackspace-titan/nova/osapi-logging-lp752663 into lp:~hudson-openstack/nova/trunk

[Brian Lamar]

Add additional logging for WSGI and OpenStack API authentication.

Add additional logging for WSGI and OpenStack API authentication.

[Brian Waldon (bcwaldon)]

Looks good! This will definitely help with future API work.

27-28: This seems like a line that would be more useful through an HTTP response to the end user, not as a log.

review: Needs Information

[Brian Lamar (blamar)]

Took your suggestion and added message to 401 response.

[Brian Waldon (bcwaldon)]

Looks good.

review: Approve

[Jay Pipes (jaypipes)]

Much needed. Keep it up! :)

review: Approve

[Devin Carlen (devcamcar)]

nice

review: Approve

=== modified file 'nova/api/openstack/auth.py'
--- nova/api/openstack/auth.py	2011-03-17 18:03:18 +0000
+++ nova/api/openstack/auth.py	2011-04-15 19:04:08 +0000
@@ -55,6 +55,9 @@
         user = self.get_user_by_authentication(req)
         accounts = self.auth.get_projects(user=user)
         if not user:
+            token = req.headers["X-Auth-Token"]
+            msg = _("%(user)s could not be found with token '%(token)s'")
+            LOG.warn(msg % locals())
             return faults.Fault(webob.exc.HTTPUnauthorized())
 
         if accounts:
@@ -66,6 +69,8 @@
 
         if not self.auth.is_admin(user) and \
            not self.auth.is_project_member(user, account):
+            msg = _("%(user)s must be an admin or a member of %(account)s")
+            LOG.warn(msg % locals())
             return faults.Fault(webob.exc.HTTPUnauthorized())
 
         req.environ['nova.context'] = context.RequestContext(user, account)
@@ -82,12 +87,16 @@
         # honor it
         path_info = req.path_info
         if len(path_info) > 1:
-            return faults.Fault(webob.exc.HTTPUnauthorized())
+            msg = _("Authentication requests must be made against a version "
+                    "root (e.g. /v1.0 or /v1.1).")
+            LOG.warn(msg)
+            return faults.Fault(webob.exc.HTTPUnauthorized(explanation=msg))
 
         try:
             username = req.headers['X-Auth-User']
             key = req.headers['X-Auth-Key']
-        except KeyError:
+        except KeyError as ex:
+            LOG.warn(_("Could not find %s in request.") % ex)
             return faults.Fault(webob.exc.HTTPUnauthorized())
 
         token, user = self._authorize_user(username, key, req)
@@ -100,6 +109,7 @@
             res.headers['X-CDN-Management-Url'] = token.cdn_management_url
             res.content_type = 'text/plain'
             res.status = '204'
+            LOG.debug(_("Successfully authenticated '%s'") % username)
             return res
         else:
             return faults.Fault(webob.exc.HTTPUnauthorized())
@@ -139,6 +149,7 @@
         try:
             user = self.auth.get_user_from_access_key(key)
         except exception.NotFound:
+            LOG.warn(_("User not found with provided API key."))
             user = None
 
         if user and user.name == username:
@@ -153,4 +164,9 @@
             token_dict['user_id'] = user.id
             token = self.db.auth_token_create(ctxt, token_dict)
             return token, user
+        elif user and user.name != username:
+            msg = _("Provided API key is valid, but not for user "
+                    "'%(username)s'") % locals()
+            LOG.warn(msg)
+
         return None, None

=== modified file 'nova/wsgi.py'
--- nova/wsgi.py	2011-04-06 21:26:50 +0000
+++ nova/wsgi.py	2011-04-15 19:04:08 +0000
@@ -43,6 +43,7 @@
 
 
 FLAGS = flags.FLAGS
+LOG = logging.getLogger('nova.wsgi')
 
 
 class WritableLogger(object):
@@ -346,6 +347,7 @@
         arg_dict = req.environ['wsgiorg.routing_args'][1]
         action = arg_dict['action']
         method = getattr(self, action)
+        LOG.debug("%s %s" % (req.method, req.url))
         del arg_dict['controller']
         del arg_dict['action']
         if 'format' in arg_dict:
@@ -361,6 +363,9 @@
             response = webob.Response()
             response.headers["Content-Type"] = content_type
             response.body = body
+            msg_dict = dict(url=req.url, status=response.status_int)
+            msg = _("%(url)s returned with HTTP %(status)d") % msg_dict
+            LOG.debug(msg)
             return response
         else:
             return result