Merge lp:~rackspace-titan/nova/lp802621 into lp:~hudson-openstack/nova/trunk
Status: | Work in progress |
---|---|
Proposed branch: | lp:~rackspace-titan/nova/lp802621 |
Merge into: | lp:~hudson-openstack/nova/trunk |
Diff against target: |
120 lines (+22/-9) 5 files modified
nova/api/openstack/images.py (+5/-1) nova/api/openstack/servers.py (+4/-1) nova/api/openstack/wsgi.py (+6/-0) nova/tests/api/openstack/test_images.py (+4/-4) nova/tests/api/openstack/test_servers.py (+3/-3) |
To merge this branch: | bzr merge lp:~rackspace-titan/nova/lp802621 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dan Prince (community) | Needs Fixing | ||
Alex Meade (community) | Approve | ||
Mark Washenberger (community) | Approve | ||
Review via email: mp+66029@code.launchpad.net |
Description of the change
I was looking for other examples in the code where we return 202 status code, and it seems we are doing it by returning webob.exc.
This seemed the least invasive way to do this for now, let me know what you think.
Unmerged revisions
- 1218. By William Wolf
-
fix image create response codes also
- 1217. By William Wolf
-
pass action to serializer
- 1216. By William Wolf
-
make create server requests return prope 202 instead of 200 response code
"I was looking for other examples in the code where we return 202 status code, and it seems we are doing it by returning webob.exc. HTTPAccepted( ) object. The problem was that nowhere else that we use that needs to return a response body as well"
Well, all the places where we are returning a 202, we *should* be returning an entity that describes the status of the request. See: http:// www.w3. org/Protocols/ rfc2616/ rfc2616- sec10.html.
-jay