> Can we add a bug for fixing the exception handling? Then I think we are clear
> to merge this.
I'm all for re-working this method, but there is no bug here as far as I'm concerned. This was all about removing a logging call which made it look like an error was occurring and checking to see if network was None.
I don't see any other bugs, so I'm a bit confused why it would hold up this prop.
But I'm still not convinced that the way Waldon did it initially isn't actually more robust. Can we at least agree that I'm looking into making it better and get this fix in?
> Can we add a bug for fixing the exception handling? Then I think we are clear
> to merge this.
I'm all for re-working this method, but there is no bug here as far as I'm concerned. This was all about removing a logging call which made it look like an error was occurring and checking to see if network was None.
I don't see any other bugs, so I'm a bit confused why it would hold up this prop.
I have this: http:// bazaar. launchpad. net/~rackspace- titan/nova/ exception- flow-logic/ revision/ 1527
But I'm still not convinced that the way Waldon did it initially isn't actually more robust. Can we at least agree that I'm looking into making it better and get this fix in?