Merge lp:~rachidbm/ubuntu-l10n-tools/pot-priority into lp:ubuntu-l10n-tools
Proposed by
Rachid
Status: | Merged |
---|---|
Merge reported by: | David Planella |
Merged at revision: | not available |
Proposed branch: | lp:~rachidbm/ubuntu-l10n-tools/pot-priority |
Merge into: | lp:ubuntu-l10n-tools |
Diff against target: |
262 lines (+141/-50) 5 files modified
ul10n_tools/lp_set_pot_priority/PotUtil.py (+82/-0) ul10n_tools/lp_set_pot_priority/__init__.py (+48/-50) ul10n_tools/lp_set_pot_priority/test.csv (+4/-0) ul10n_tools/ul10n_toolsconfig.py (+1/-0) ul10n_tools/utils/launchpadmanager.py (+6/-0) |
To merge this branch: | bzr merge lp:~rachidbm/ubuntu-l10n-tools/pot-priority |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Approve | ||
Review via email: mp+64016@code.launchpad.net |
This proposal supersedes a proposal from 2011-06-09.
Description of the change
Retrieve active series from Launchpad
Added class to handle the stuff regarding POT and Launchpad
Prioritise just one template or give an CSV file
Edit 1 pot over several distro codenames
Removed unnecessary has_header check in CSV reader
Removed obsolete imports
To post a comment you must log in.
Looks good, thanks Rachid!
Just a couple of things
* On ul10n_tools/ lp_set_ pot_priority/ __init_ _.py the "The missing bits from the API are the traversal bits where you'd be able to walk" line and others introduce unnecessary trailing space. Please try to look at the diff before sending future merge proposals /wiki.ubuntu. com/MeetingLogs /appdevweek1104 /RockSolidPytho n lp_set_ pot_priority/ , as in principle it should be not directly related to setting the priority, but rather in the future it should be able to set any template properties-
* The new test.csv file has a line with an invalid prioritiy (72a00). Is this intentional?
* It'd be great to start adding automated tests for all tools, and move away this .csv file to be part of the tests. Some background info: https:/
* I'd suggest moving the PotUtil module somewhere else rather than inside ul10n_tools/
These are not blockers, so I'll merge the branch now. Good work!