Merge ~racb/usd-importer:exception-handling into usd-importer:master

[Robie Basak]

[Scott Moser (smoser)]

You might as well add sane messages to the exceptions that you are fixing.
i see many aren't trivial a message for, but if its easy, putting more info in the exception message seems useful.

[Robie Basak (racb)]

Sure, but I didn't write the code so I don't know exactly what they are and didn't spend time trying to find out. I was just passing through. I'm just trying to make things incrementally better :-)

[Nish Aravamudan (nacc)]

I added a follow-on commit with messages and pushed up to master.

[Nish Aravamudan (nacc)]

review: Approve

diff --git a/usd/build.py b/usd/build.py
index dc689e1..866dae0 100644
--- a/usd/build.py
+++ b/usd/build.py
@@ -211,7 +211,7 @@ class USDBuild:
                                     pkgname, distname)
 
         if not upstream_version_found:
-            raise NoUpstreamFoundException
+            raise NoUpstreamFoundException()
 
         # symlink orig tarballs
         for entry in dsc['Files']:
diff --git a/usd/git_repository.py b/usd/git_repository.py
index 93aa853..ccd0efb 100644
--- a/usd/git_repository.py
+++ b/usd/git_repository.py
@@ -247,7 +247,7 @@ class USDGitRepository:
             # Does not seem to be working with https
             # self.local_repo.remotes[remote_name].fetch()
             self.git_run(['fetch', remote_name])
-        except:
+        except CalledProcessError:
             logging.info('No objects found in remote %s', remote_url)
 
         self.local_repo.remotes.set_push_url(remote_name,
diff --git a/usd/importer.py b/usd/importer.py
index 73de6a6..eb407e1 100755
--- a/usd/importer.py
+++ b/usd/importer.py
@@ -374,7 +374,7 @@ class USDImport:
                 break
         if extracted_dir is None:
             logging.exception('No source extracted?')
-            raise SourceExtractionException
+            raise SourceExtractionException()
 
         self.local_repo.git_run(['--work-tree', extracted_dir, 'add', '-f', '-A'])
         cp = self.local_repo.git_run(['--work-tree', extracted_dir, 'write-tree'])
@@ -411,7 +411,7 @@ class USDImport:
                 break
         if extracted_dir is None:
             logging.exception('No source extracted?')
-            raise SourceExtractionException
+            raise SourceExtractionException()
 
         if os.path.isdir(os.path.join(extracted_dir, '.pc')):
             self.local_repo.git_run(['--work-tree', extracted_dir, 'add', '-f', '-A'])
@@ -425,7 +425,7 @@ class USDImport:
                 cp = run(['dpkg-source', '--print-format', extracted_dir])
                 fmt = decode_binary(cp.stdout).strip()
                 if '3.0 (quilt)' not in fmt:
-                    raise StopIteration
+                    raise StopIteration()
             except CalledProcessError as e:
                 try:
                     with open('debian/source/format', 'r') as f:
@@ -433,10 +433,10 @@ class USDImport:
                              if re.match(r'3.0 (.*)', line):
                                  break
                         else:
-                             raise StopIteration
+                             raise StopIteration()
                 # `man dpkg-source` indicates no d/s/format implies 1.0
                 except OSError:
-                    raise StopIteration
+                    raise StopIteration()
 
             while True:
                 try:
@@ -467,7 +467,7 @@ class USDImport:
                     # quilt returns 2 when done pushing
                     if e.returncode != 2:
                         raise
-                    raise StopIteration
+                    raise StopIteration()
         finally:
             os.chdir(oldcwd)
             shutil.rmtree(extract_dir)
diff --git a/usd/source_information.py b/usd/source_information.py
index c6a74be..566a77f 100644
--- a/usd/source_information.py
+++ b/usd/source_information.py
@@ -249,7 +249,7 @@ class USDSourceInformation(object):
 
         spph = self.dist.main_archive.getPublishedSources(**args)
         if len(spph) == 0:
-            raise NoPublicationHistoryException
+            raise NoPublicationHistoryException()
 
         for srcpkg in spph:
             yield self.get_corrected_spi(srcpkg, workdir)
@@ -280,7 +280,7 @@ class USDSourceInformation(object):
         # Sanity check that the passed in srcpkg name has a publication
         # history
         if len(spph) == 0:
-            raise NoPublicationHistoryException
+            raise NoPublicationHistoryException()
         if len(head_versions) > 0:
             _spph = list()
             for spphr in spph:
@@ -311,7 +311,7 @@ class USDSourceInformation(object):
                 )
                )
             yield self.get_corrected_spi(srcpkg, workdir)
-        raise StopIteration
+        raise StopIteration()
 
     def parse_pullfile(self, pullfile):
         """Extract source file overrides from a file