Code review comment for lp:~racb/ubuntu/saucy/autopkgtest/lxc

Hey Robie, many thanks for working on this! That's a nice addition.

Some things which I noticed during first spot-check:

+# autopkgtest is Copyright (C) 2006-2007 Canonical Ltd.

Please add a copyright for you, you wrote that file after all.

127 + lxc_container_name = 'adt-virt-lxc-' + ''.join([random.choice(string.ascii_lowercase) for i in range(6)])
128 + vsp.execute('sudo lxc-start-ephemeral -n %s --keep-data -d -o' % lxc_container_name,[lxc_template], downp=False, outp=True)

I'm not entirely sure what that does, but it looks like lxc_container_name is a temporary file name of some sort? Would it be more adequate to use the standard mkstemp() function, or is that really just a name? In the latter case, how does this make sure that it doesn't use an existing name?