Merge lp:~racb/ubuntu/oneiric/samba/862129 into lp:ubuntu/oneiric/samba

[Robie Basak]

This fixes my test case in bug 862129.

[Robie Basak (racb)]

Outstanding questions I posted from that bug that I would like reviewed before merging:

1) Is this the right approach?
2) Is dpkg-query the right way to get the status of the update-inetd package?
3) What about triggers-awaiting and triggers-pending? What should the behaviour be in these cases? Is it OK to treat update-inetd as not available in these cases?

Thanks.

[Colin Watson (cjwatson)]

The effect of this change is to make the system non-deterministic. If
we want update-inetd to work from postrm scripts, don't we instead need
to make sure that it always works even if unconfigured, as if it were an
Essential package? This would be much safer and the resulting system
would be easier to understand.

I'm also unconvinced about the reliability of the data returned by
dpkg-query from a maintainer script. It may be better now, but
historically this didn't reliably reflect the state of a running dpkg
instance.

To be honest, I think there are too many questions about this kind of
thing for it to be safe to attempt a fix for this for oneiric. I'd
rather we got it right in precise, and then maybe backported the fix.

[Adam Conrad (adconrad)]

It might be worth pointing out that calling update-inetd in a postrm is vaguely crack anyway, as we're removing the service entries AFTER we've removed the binaries from the disk.

Moving the update-inetd call to prerm (where I'd argue it belongs) solves everything we're trying to solve with this complex branch, since the dependencies are still there during prerm.

[Robie Basak (racb)]

Thanks Colin and Adam.

I was trying to do the minimal change possible to get the fix into oneiric - as it's causing upgrade failures at the moment. If that's not going to happen, then I'll file a Debian bug as the postrm hasn't been modified by Ubuntu in any way.

Unmerged revisions

148. By Robie Basak on 2011-10-10

debian/samba.postrm: check that update-inetd is configured and in all code
paths. (LP: #862129)

=== modified file 'debian/changelog'
--- debian/changelog	2011-09-30 13:08:34 +0000
+++ debian/changelog	2011-10-10 15:49:26 +0000
@@ -1,3 +1,10 @@
+samba (2:3.5.11~dfsg-1ubuntu3) oneiric; urgency=low
+
+  * debian/samba.postrm: check that update-inetd is configured and in all code
+    paths. (LP: #862129)
+
+ -- Robie Basak <[e-mail]>  Mon, 10 Oct 2011 15:18:13 +0100
+
 samba (2:3.5.11~dfsg-1ubuntu2) oneiric; urgency=low
 
   * debian/patches/fix-debuglevel-name-conflict.patch:

=== modified file 'debian/samba.postrm'
--- debian/samba.postrm	2008-11-05 03:24:52 +0000
+++ debian/samba.postrm	2011-10-10 15:49:26 +0000
@@ -1,5 +1,19 @@
 #!/bin/sh -e
 
+try_update_inetd() {
+	[ -x /usr/sbin/update-inetd ] || return 0
+	status=`dpkg-query '-f${Status}' -W update-inetd`
+	status_f3=`echo "$status"|(read f1 f2 f3 rest;echo $f3)`
+	case "$status_f3" in
+		installed)
+			update-inetd "$@"
+			;;
+
+		*)	echo Skipping update-inetd: not configured >&2
+			;;
+	esac
+}
+
 if [ "$1" = purge ]; then
 	rm -rf /var/cache/samba/browse.dat
 	rm -rf /var/lib/samba/printers/
@@ -11,12 +25,10 @@
 	rm -f /etc/default/samba
 
 	# Remove NetBIOS entries from /etc/inetd.conf
-	if [ -x /usr/sbin/update-inetd ]; then
-		update-inetd --remove netbios-ssn
-	fi
+	try_update_inetd --remove netbios-ssn
 else
 	# Not purging, do not remove NetBIOS entries from /etc/inetd.conf
-	update-inetd --disable netbios-ssn
+	try_update_inetd --disable netbios-ssn
 
 fi