Merge ~racb/ubuntu/+source/php-horde-db:mysql-integer-column-limit into ubuntu/+source/php-horde-db:ubuntu/devel

Proposed by Robie Basak
Status: Merged
Approved by: Robie Basak
Approved revision: 3be1db36119e8253910bed36b7d40dc9e32bc74f
Merged at revision: 3be1db36119e8253910bed36b7d40dc9e32bc74f
Proposed branch: ~racb/ubuntu/+source/php-horde-db:mysql-integer-column-limit
Merge into: ubuntu/+source/php-horde-db:ubuntu/devel
Diff against target: 55 lines (+33/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/mysql-integer-column-limit.patch (+25/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server MOTU reviewers Pending
Review via email:
To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

I've tested that this passes dep8. In a lxd environment I got unrelated warnings that necessitated a "allow-stderr" restriction before tests would pass; I haven't included that change here as I believe it should be fine in the archive as we didn't see those errors in the archive previously.

Revision history for this message
Bryce Harrington (bryce) wrote :

* Changelog:
  - [ ] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [ ] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
    + Test has seen no code updates in a few years.
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [-] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [-] no new patches added
  - [x] patches match what was proposed upstream
    + The patch is not attached to the upstream bug report.
  - [√] patches correctly included in debian/patches/series
  - [√] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
    + Instead of a PPA, I debuild'd the package and installed the .deb
  - [√] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

I also saw weirdness running the autopkgtest in my local lxc. Hopefully it should work cleanly in the archive.

I wonder if it would be useful to also post the patch to the upstream bug report? Your description is really clear so probably not strictly necessary but might help it get attention.

Anyway, for the package itself it all LGTM, +1.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index bdac6bf..c4d4b8e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1php-horde-db (2.4.0-4ubuntu4) focal; urgency=medium
3 * d/p/mysql-integer-column-limit.patch: adjust test for MySQL >= 8.0.19
4 behaviour (LP: #1861099).
6 -- Robie Basak <> Tue, 28 Jan 2020 14:32:30 +0000
1php-horde-db (2.4.0-4ubuntu3) focal; urgency=medium8php-horde-db (2.4.0-4ubuntu3) focal; urgency=medium
3 * Stop using adsrc. No idea if this will work, but hey tests pass.10 * Stop using adsrc. No idea if this will work, but hey tests pass.
diff --git a/debian/patches/mysql-integer-column-limit.patch b/debian/patches/mysql-integer-column-limit.patch
4new file mode 10064411new file mode 100644
index 0000000..b084573
--- /dev/null
+++ b/debian/patches/mysql-integer-column-limit.patch
@@ -0,0 +1,25 @@
1Description: adjust test to match MySQL's new behaviour since 8.0.19
2 This patch is sufficient to cause the test to pass in the archive, where we
3 know that nothing else depends on the old behaviour. See the Launchpad bug for
4 details. It is unclear what solution would be better more generally; we can
5 see what upstream's view on this is in the upstream bug.
6Author: Robie Basak <>
9Forwarded: not-needed
10Last-Update: 2020-01-28
12--- a/Horde_Db-2.4.0/test/Horde/Db/Adapter/MysqlBase.php
13+++ b/Horde_Db-2.4.0/test/Horde/Db/Adapter/MysqlBase.php
14@@ -257,9 +257,9 @@
15 public function testColumns()
16 {
17 $col = parent::testColumns();
18- $this->assertEquals(10, $col->getLimit());
19+ $this->assertEquals(null, $col->getLimit());
20 $this->assertEquals(true, $col->isUnsigned());
21- $this->assertEquals('int(10) unsigned', $col->getSqlType());
22+ $this->assertEquals('int unsigned', $col->getSqlType());
23 }
25 public function testCreateTableWithSeparatePk()
diff --git a/debian/patches/series b/debian/patches/series
index d98d236..538042e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -3,3 +3,4 @@ phpunit6_compat.patch


People subscribed via source and target branches