Merge ~racb/ubuntu/+source/mongodb:core-split into ubuntu/+source/mongodb:ubuntu/devel

[Robie Basak]

See bug and changelog entry for details.

Note: this tree has empty directories, so the pushing of the upload tag as-is will not work.

[Christian Ehrhardt  (paelzer)]

No Diff, so no inline comments- sorry:

On replaces and breaks:
  mongodb-server (<= 1:3.4.7-1ubuntu2)
should be
  mongodb-server (<= 1:3.4.7-1ubuntu2~)

Other than that it looks correct, but I want to test upgrade paths and such a bit.
I pinged you on IRC if you have built it somewhere already.

review: Needs Fixing

[Christian Ehrhardt  (paelzer)]

Interesting - your last upload had [1] - which is related to my comment above.
Would you mind explaining why you did so ?

[1]: https://launchpadlibrarian.net/357285769/mongodb_1%3A3.4.7-1ubuntu3~ppa1_1%3A3.4.7-1ubuntu3~ppa2.diff.gz

review: Needs Information

[Robie Basak (racb)]

On Tue, Mar 20, 2018 at 01:16:18PM -0000, ChristianEhrhardt wrote:
> On replaces and breaks:
> mongodb-server (<= 1:3.4.7-1ubuntu2)
> should be
> mongodb-server (<= 1:3.4.7-1ubuntu2~)

I thought that too, but this failed in testing. The reason is that
(<= 1:3.4.7-1ubuntu2~) is not true when upgrading from
1:3.4.7-1ubuntu2, but I need it to be true.

In general the 2~ needs to be included any time the 2 is included. In
this case, since the match is <=, using 2 includes both 2 and 2~ as
needed.

I'm not sure if I have given you bad advice on this in the past because
I didn't consider this reversal of the norm previously either. If I did,
sorry!

[Christian Ehrhardt  (paelzer)]

3~ is actually the right thing as you are uploading 3
I didn't realize this is 3 as your dep was on 2.

I think it should be
  mongodb-server (<= 1:3.4.7-1ubuntu3~)

[Christian Ehrhardt  (paelzer)]

We agreed on the versioning and keep it as is.

[Christian Ehrhardt  (paelzer)]

Basic tests done and checked upgrade paths.

I wonder if you'd want to run http://paste.ubuntu.com/p/HT7FmFzB3F/ before the upload?

review: Approve

[Robie Basak (racb)]

These tests seem to consistently fail in Bionic, so I'm not sure I'm getting anything useful out of them for this MP.

Bionic:

FAILED (SKIP=54, errors=90, failures=1)

My PPA:

FAILED (SKIP=54, errors=13)

So it's seems to not cause some catastrophic regression at least. Given the nature of my changes, I think any regression is likely to be either catastrophic (something doesn't work at all) rather than any more subtle problem. Though a subtle problem might be introduced by a latent bug in a rebuild, I don't think we usually worry about that in terms of landing changes during the development cycle.

[Robie Basak (racb)]

Uploaded without pushing upload tag due to the empty directory workflow bug.