Merge ~racb/ubuntu/+source/mongodb:major-minor-ftbfs into ~usd-import-team/ubuntu/+source/mongodb:ubuntu/devel
| Status: | Needs review |
|---|---|
| Proposed branch: | ~racb/ubuntu/+source/mongodb:major-minor-ftbfs |
| Merge into: | ~usd-import-team/ubuntu/+source/mongodb:ubuntu/devel |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ChristianEhrhardt | 2017-12-18 | Approve on 2017-12-19 | |
| Canonical Server Team | 2017-12-18 | Pending | |
|
Review via email:
|
|||
| Robie Basak (racb) wrote : | # |
| Robie Basak (racb) wrote : | # |
Building locally with sbuild fails, hanging at a test step indefinitely, unless the tests are skipped with DEB_BUILD_
| ChristianEhrhardt (paelzer) wrote : | # |
Patch in d/p:
- matches upstream, link ok
- debain bug ok
- could have a .patch ending but I see mongodb already has non suffix patches, so ok
changelog: LGTM
Arch builds:
- especially with so many special bells and whistles as you outlined e.g. in regard to no-sbuild we should really run all builds before an upload to be sure.
I opened one for you at [1] to build all archs - please check the result before uploading.
In general I fixed similar issues with similar changes, so I also overall agree to the fix as it was pulled from upstream.
If you plan to feed that back to Debian (only Debian bug linked) please mind that there 2.26 is only in experimental now (this stopped some of my feed-back activities).
[1]: https:/
Unmerged commits
- 6cea77c... by Robie Basak on 2017-12-18
- 19fdfd7... by Robie Basak on 2017-12-18
- 0a476ff... by Robie Basak on 2017-12-18


Pending build test in ppa:racb/ experimental. Also I had an oops from LP about the diff generation, so reviewers will need to review locally. Sorry!