Merge ~racb/ubuntu/+source/dovecot:glibc-crypt-ftbfs into ubuntu/+source/dovecot:ubuntu/devel

Proposed by Robie Basak
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: 2f04799598b195f4cd1b79e24c86b915844e313c
Proposed branch: ~racb/ubuntu/+source/dovecot:glibc-crypt-ftbfs
Merge into: ubuntu/+source/dovecot:ubuntu/devel
Diff against target: 81 lines (+59/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-glibc-crypt-ftbfs (+51/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server packageset reviewers Pending
Review via email: mp+355399@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Code, CL, and build LGTM now - thanks for the debugging!

Revision history for this message
Christian Ehrhardt  (paelzer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 69cd5e5..0357a6a 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+dovecot (1:2.3.2.1-1ubuntu2) cosmic; urgency=medium
7+
8+ * d/p/fix-glibc-crypt-ftbfs: cherry-pick from upstream to find crypt(3)
9+ correctly to fix FTBFS (LP: #1793138).
10+
11+ -- Robie Basak <robie.basak@ubuntu.com> Thu, 20 Sep 2018 08:51:00 +0100
12+
13 dovecot (1:2.3.2.1-1ubuntu1) cosmic; urgency=medium
14
15 * Merge with Debian unstable (LP: #1771524). Remaining changes:
16diff --git a/debian/patches/fix-glibc-crypt-ftbfs b/debian/patches/fix-glibc-crypt-ftbfs
17new file mode 100644
18index 0000000..f4d06c8
19--- /dev/null
20+++ b/debian/patches/fix-glibc-crypt-ftbfs
21@@ -0,0 +1,51 @@
22+From 63a74b9e8e0604486a15a879e7f1a27257322400 Mon Sep 17 00:00:00 2001
23+From: Aki Tuomi <aki.tuomi@dovecot.fi>
24+Date: Wed, 8 Aug 2018 12:33:20 +0300
25+Subject: [PATCH] auth: mycrypt - include crypt.h
26+MIME-Version: 1.0
27+Content-Type: text/plain; charset=UTF-8
28+Content-Transfer-Encoding: 8bit
29+
30+Fixes crypt usage on glibc-2.28
31+
32+Reported by Reuben Farrelly
33+Patch provided by Thore Bödecker
34+
35+Bug-Ubuntu: https://launchpad.net/bugs/1793138
36+Origin: upstream, https://github.com/dovecot/core/commit/63a74b9e8e0604486a15a879e7f1a27257322400
37+Last-Update: 2018-09-20
38+---
39+ configure.ac | 2 +-
40+ src/auth/mycrypt.c | 3 +++
41+ 2 files changed, 4 insertions(+), 1 deletion(-)
42+
43+diff --git a/configure.ac b/configure.ac
44+index dd545eb..c5d8fae 100644
45+--- a/configure.ac
46++++ b/configure.ac
47+@@ -315,7 +315,7 @@ AC_CHECK_HEADERS(strings.h stdint.h unistd.h dirent.h malloc.h \
48+ quota.h sys/fs/quota_common.h \
49+ mntent.h sys/mnttab.h sys/event.h sys/time.h sys/mkdev.h linux/dqblk_xfs.h \
50+ xfs/xqm.h execinfo.h ucontext.h malloc_np.h sys/utsname.h sys/vmount.h \
51+- sys/utsname.h glob.h linux/falloc.h ucred.h sys/ucred.h)
52++ sys/utsname.h glob.h linux/falloc.h ucred.h sys/ucred.h crypt.h)
53+
54+ CC_CLANG
55+ AC_CC_PIE
56+diff --git a/src/auth/mycrypt.c b/src/auth/mycrypt.c
57+index c49fcf8..0bd00bc 100644
58+--- a/src/auth/mycrypt.c
59++++ b/src/auth/mycrypt.c
60+@@ -14,6 +14,9 @@
61+ # define _XPG6 /* Some Solaris versions require this, some break with this */
62+ #endif
63+ #include <unistd.h>
64++#ifdef HAVE_CRYPT_H
65++# include <crypt.h>
66++#endif
67+
68+ #include "mycrypt.h"
69+
70+--
71+2.7.4
72+
73diff --git a/debian/patches/series b/debian/patches/series
74index e4b328a..c999538 100644
75--- a/debian/patches/series
76+++ b/debian/patches/series
77@@ -8,3 +8,4 @@ mboxlocking.patch
78 dovecot_name.patch
79 ssl-dh-params-location.patch
80 debian-changes
81+fix-glibc-crypt-ftbfs

Subscribers

People subscribed via source and target branches