~racb/ubuntu-sponsoring:git-mps

Last commit made on 2022-07-01
Get this branch:
git clone -b git-mps https://git.launchpad.net/~racb/ubuntu-sponsoring
Only Robie Basak can upload to this branch. If you are Robie Basak please log in for upload directions.

Branch merges

Branch information

Name:
git-mps
Repository:
lp:~racb/ubuntu-sponsoring

Recent commits

29422de... by Robie Basak

Add git MP support

Various people have been submitting MPs against git-ubuntu branches,
even though we haven't specifically been calling for these yet.

This adds support to make these MPs appear on the sponsoring page so
they don't get lost.

This is done by implementing get_git_branches() on the same lines as the
existing (bzr-specific) get_branches().

Since the Launchpad API getRequestedReviews() method doesn't yet support
git branches (LP 1979817), this is implemented by scraping the web UI
instead. This is done in lp_scrape_mps.py, added as a separate module.
I've been using this scraping elsewhere, so it's copied in from the
ubuntu-helpers repository where I've been keeping a master copy. It'd be
better to provide it as a library somewhere, but we don't currently have
a mechanism to do that since the machine that runs the sponsoring report
is quite far behind. So, for now, I'm making do with a copy which we
will need to maintain manually.

b768b11... by Robie Basak

Fix team parameter against sponsorship teams

SPONSOR_TEAMS is a dictionary keyed by "general" and "security". The
values contain the actual Launchpad team names.

When we iterate over SPONSOR_TEAMS, we should pass the actual Launchpad
team names to get_bugs() and get_branches(), not the "general" or
"security" str key.

Otherwise, when we call get_branches(), it will look for Launchpad teams
called "general" and "security". These usernames happen to exist but the
behaviour will not work as intended.

get_branches() previously was not working correctly because it was being
passed a key into SPONSOR_TEAMS as its "team" parameter but assumed it
was directly a Launchpad team name.

get_bugs() previously worked around this by assuming that its "team"
parameter is a key into SPONSOR_TEAMS, but this is a leaky abstraction
and is confusing.

This change unifies these functions by always passing "team" as a
Launchpad team name. get_bugs() is changed to handle the Launchpad team
directly instead of looking it up against SPONSOR_TEAMS.

dccda0d... by Sebastien Bacher

Rename time_in_queue to date_queued to better match the content

776c9fb... by Sebastien Bacher

Fix spacing issues

a02c71b... by Sebastien Bacher

Include extra details in the json reports

2eaec70... by Sebastien Bacher

Write the json reports in a subdir

It's easier to list them this way. Keep the old location for compatibility

914e388... by Simon Quigley

Migrate to HTML 5.

476231f... by Simon Quigley

Add the bootstrap theme to the template to make the page much less jarring.

577ae02... by Simon Quigley

Small grammar fix.

269859a... by Simon Quigley

Move .bzrignore to .gitignore.