Merge ~racb/ubuntu-archive-tools:sru-release-freeze into ubuntu-archive-tools:main

[Robie Basak]

[Robie Basak (racb)]

Before landing, we need to decide where the freeze information should live, push my example freeze data repository there, and update the URL in sru-release.

This introduces a dependency on python3-yaml as that's the easiest way to load a set. I think that should be OK.

We're locking in the format of the data file a little bit here, but I don't think that should be a problem. In the future we might want freeze information bounded by dates, for example. But this should do for now, and if we do change the data format in the future, it shouldn't be a big deal just to ask SRU team members to update their checkout of ubuntu-archive-tools.

Unmerged commits

cb7dca7... by Robie Basak on 2023-08-09

sru-release: deny release for frozen series

We keep having accidents where SRU team members forget that a particular
release is in freeze and release to it anyway.

Instead of just remembering freeze emails, we should fix this in
tooling. Now, as long as the release team mark a release as frozen,
sru-release will refuse to release to it unless --force is used. --force
is intended to allow release team members to allow SRU releases through
that are intended for a point release.

diff --git a/sru-release b/sru-release
index a72eef3..814ef23 100755
--- a/sru-release
+++ b/sru-release
@@ -35,6 +35,7 @@ import subprocess
 import sys
 import time
 import unittest
+import yaml
 
 from six.moves.urllib.request import urlopen
 from io import TextIOWrapper
@@ -443,6 +444,9 @@ if __name__ == '__main__':
     parser.add_option(
         '-C', '--cache', default='~/.cache/sru-release',
         help='Cache directory to be used for the britney hints checkout')
+    parser.add_option(
+        '--force', default=False, action='store_true',
+        help='Override some errors that otherwise block release')
 
     options, args = parser.parse_args()
 
@@ -478,6 +482,12 @@ if __name__ == '__main__':
             sys.exit(1)
         os.makedirs(options.cache)
 
+    with urlopen('https://git.launchpad.net/~racb/+git/sru-freezes/plain/sru-freezes.yaml?h=main') as request:
+        frozen_releases = yaml.safe_load(request.read(2**10))
+    if release in frozen_releases and not options.force:
+        print("Release %s is in freeze and --force not specified" % release)
+        sys.exit(1)
+
     launchpad = Launchpad.login_with(
         'ubuntu-archive-tools', options.launchpad_instance, version='devel')
     ubuntu = launchpad.distributions['ubuntu']