Merge lp:~racb/maas/ipmipower-stdin-lp-1053391 into lp:~maas-committers/maas/trunk

Proposed by Robie Basak
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 1038
Proposed branch: lp:~racb/maas/ipmipower-stdin-lp-1053391
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 11 lines (+2/-0)
1 file modified
src/provisioningserver/power/templates/ipmi.template (+2/-0)
To merge this branch: bzr merge lp:~racb/maas/ipmipower-stdin-lp-1053391
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+125518@code.launchpad.net

Commit message

Work around ipmipower requiring input on stdin

ipmipower doesn't work with stdin connected to /dev/null, so connect it to something else as a workaround.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

That's, errr, special. :(

Thanks for the fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/provisioningserver/power/templates/ipmi.template'
2--- src/provisioningserver/power/templates/ipmi.template 2012-09-17 17:27:02 +0000
3+++ src/provisioningserver/power/templates/ipmi.template 2012-09-20 15:57:23 +0000
4@@ -23,6 +23,8 @@
5
6 # Issue command to ipmipower, for the given system.
7 issue_ipmi_command() {
8+ # See https://launchpad.net/bugs/1053391 for details of this workaround
9+ echo workaround |\
10 ${ipmipower} -h ${power_address} -u ${power_user} -p ${power_pass} --$1
11 }
12