~racb/git-ubuntu:plus-sign-branch-name

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

b3620fb... by Robie Basak on 2022-07-01

Improve documentation on validation constants

This should hopefully do a better job of signposting anyone who wants to
change the constants to better understand the implications of doing so.

46410e6... by Robie Basak on 2022-07-01

Add test to accept refs that contain '+'

a246ee9... by Sergio Durigan Junior on 2022-06-16

Accept ref names containing plus sign

Currently, if the ref name contains a plus sign, git ubuntu will fail
due to the following assertion error:

Traceback (most recent call last):
  File "/snap/git-ubuntu/891/usr/bin/git-ubuntu", line 11, in <module>
    load_entry_point('gitubuntu==1.0', 'console_scripts', 'git-ubuntu')()
  File "/snap/git-ubuntu/891/usr/lib/python3/dist-packages/gitubuntu/__main__.py", line 270, in main
    sys.exit(args.func(args))
  File "/snap/git-ubuntu/891/usr/lib/python3/dist-packages/gitubuntu/prepare_upload.py", line 170, in cli_printargs
    headers = push(
  File "/snap/git-ubuntu/891/usr/lib/python3/dist-packages/gitubuntu/prepare_upload.py", line 118, in push
    assert gitubuntu.importer.VCS_GIT_REF_VALIDATION.fullmatch(ref.name)
AssertionError

However, branch names (which compose ref names) are allowed to contain
the plus sign. This commit expands the VCS_GIT_REF_VALIDATION regexp
to accept that.

FWIW, I triggered this assertion when I named my branch after the
Debian release I was merging (for the net-snmp package):

  merge-5.9.1+dfsg-4-kinetic

5aad111... by Robie Basak on 2022-05-20

Update default bot account name

usd-importer-bot is now renamed to git-ubuntu-bot as part of catching up
the project rename to git-ubuntu.

2f0e855... by Robie Basak on 2022-05-20

Update email address default used in tests

Since <email address hidden> no longer exists, we'll use
<email address hidden> instead. This shouldn't affect
production code since the repo_builder and source_builder modules are
only used in tests.

002e452... by Robie Basak on 2022-05-20

Update email address to request an import

This is for the message printed when a repository is not found on "git
ubuntu clone".

Since <email address hidden> no longer exists, we'll use
<email address hidden> instead.

57e5776... by Robie Basak on 2022-05-20

Update maintainer email address

<email address hidden> no longer exists. Use
<email address hidden> instead.

ef3b3a9... by Robie Basak on 2022-05-20

Merge remote-tracking branch 'lvoytek/master'

d1858ec... by Robie Basak on 2022-05-18

Merge remote-tracking branch 'athos-ribeiro/leaking-perl-with-wrappers'

94d3a81... by Athos Ribeiro on 2022-04-08

Check if perl dependent commands are runnable

These binaries used to load dependencies from the host. This could
result in broken binaries. This test ensure these commands are runnable.

To do so, this patch refactors the test_*_runnable integration tests
into a single, parametrized, test_command_runnable test.