Merge ~r41k0u/ubuntu/+source/needrestart:ubuntu/plucky into ubuntu/+source/needrestart:ubuntu/devel

Proposed by Pragyansh Chaturvedi
Status: Needs review
Proposed branch: ~r41k0u/ubuntu/+source/needrestart:ubuntu/plucky
Merge into: ubuntu/+source/needrestart:ubuntu/devel
Diff against target: 53 lines (+31/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Simon Quigley (community) Approve
Review via email: mp+477718@code.launchpad.net

Commit message

* Don't restart keepalived automatically (LP: #2089155)
  - d/p/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch:
    Add regex to ignore keepalived for automatic restart
  - d/p/series: Add new patch to patch series

To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) wrote :

Looks like this was already uploaded, retroactively approving.

review: Approve

Unmerged commits

c299d68... by Pragyansh Chaturvedi

changelog

0cf3626... by Pragyansh Chaturvedi

* Don't restart keepalived automatically (LP: #2089155)
   - d/p/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch:
     Add regex to ignore keepalived for automatic restart
   - d/p/series: Add new patch to patch series

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 0a4203f..76a5bb1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
1needrestart (3.6-8ubuntu7) plucky; urgency=medium
2
3 * Don't restart keepalived automatically (LP: #2089155)
4 - d/p/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch:
5 Add regex to ignore keepalived and for automatic restart
6 - d/p/series: Add new patch to patch series
7
8 -- Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com> Wed, 04 Dec 2024 15:10:53 +0530
9
1needrestart (3.6-8ubuntu6) plucky; urgency=medium10needrestart (3.6-8ubuntu6) plucky; urgency=medium
211
3 * SECURITY UPDATE: incorrect usage of PYTHONPATH environment variable12 * SECURITY UPDATE: incorrect usage of PYTHONPATH environment variable
diff --git a/debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch b/debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch
4new file mode 10064413new file mode 100644
index 0000000..7f7591d
--- /dev/null
+++ b/debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch
@@ -0,0 +1,21 @@
1Description: Don't restart keepalived automatically
2 Add regex to prevent keepalived from restarting automatically.
3 keepalived should not automatically restart after an update.
4 Other services can depend on it and it's state and might get
5 disrupted due to an unwanted / unplanned restart. It should be
6 deferred.
7Author: Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com>
8Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2089155
9Last-Update: 2024-12-04
10---
11--- a/ex/needrestart.conf 2024-12-04 14:53:41.332394779 +0530
12+++ b/ex/needrestart.conf 2024-12-04 14:57:20.894419046 +0530
13@@ -122,6 +122,8 @@
14 qr(^google-(shutdown|startup)-scripts\.service$) => 0,
15 # LP: #2067800
16 qr(^runner-provisionner\.service$) => 0,
17+ # LP: #2089155
18+ qr(^keepalived\.service$) => 0,
19
20 # systemd stuff
21 # (see also Debian Bug#784238 & #784437)
diff --git a/debian/patches/series b/debian/patches/series
index 11eb73e..c6d7b74 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -21,3 +21,4 @@ CVE-2024-11003.patch
21CVE-2024-48992.patch21CVE-2024-48992.patch
22CVE-2024-48990.patch22CVE-2024-48990.patch
23CVE-2024-48991.patch23CVE-2024-48991.patch
24lp2089155/0020-ubuntu-avoid-restart-keepalived.patch

Subscribers

People subscribed via source and target branches