Merge ~r41k0u/ubuntu/+source/needrestart:ubuntu/plucky into ubuntu/+source/needrestart:ubuntu/devel

Proposed by Pragyansh Chaturvedi
Status: Needs review
Proposed branch: ~r41k0u/ubuntu/+source/needrestart:ubuntu/plucky
Merge into: ubuntu/+source/needrestart:ubuntu/devel
Diff against target: 53 lines (+31/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch (+21/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Simon Quigley (community) Approve
Review via email: mp+477718@code.launchpad.net

Commit message

* Don't restart keepalived automatically (LP: #2089155)
  - d/p/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch:
    Add regex to ignore keepalived for automatic restart
  - d/p/series: Add new patch to patch series

To post a comment you must log in.
Revision history for this message
Simon Quigley (tsimonq2) wrote :

Looks like this was already uploaded, retroactively approving.

review: Approve

Unmerged commits

c299d68... by Pragyansh Chaturvedi

changelog

0cf3626... by Pragyansh Chaturvedi

* Don't restart keepalived automatically (LP: #2089155)
   - d/p/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch:
     Add regex to ignore keepalived for automatic restart
   - d/p/series: Add new patch to patch series

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 0a4203f..76a5bb1 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+needrestart (3.6-8ubuntu7) plucky; urgency=medium
7+
8+ * Don't restart keepalived automatically (LP: #2089155)
9+ - d/p/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch:
10+ Add regex to ignore keepalived and for automatic restart
11+ - d/p/series: Add new patch to patch series
12+
13+ -- Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com> Wed, 04 Dec 2024 15:10:53 +0530
14+
15 needrestart (3.6-8ubuntu6) plucky; urgency=medium
16
17 * SECURITY UPDATE: incorrect usage of PYTHONPATH environment variable
18diff --git a/debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch b/debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch
19new file mode 100644
20index 0000000..7f7591d
21--- /dev/null
22+++ b/debian/patches/lp2089155/0020-ubuntu-avoid-restart-keepalived.patch
23@@ -0,0 +1,21 @@
24+Description: Don't restart keepalived automatically
25+ Add regex to prevent keepalived from restarting automatically.
26+ keepalived should not automatically restart after an update.
27+ Other services can depend on it and it's state and might get
28+ disrupted due to an unwanted / unplanned restart. It should be
29+ deferred.
30+Author: Pragyansh Chaturvedi <pragyansh.chaturvedi@canonical.com>
31+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/needrestart/+bug/2089155
32+Last-Update: 2024-12-04
33+---
34+--- a/ex/needrestart.conf 2024-12-04 14:53:41.332394779 +0530
35++++ b/ex/needrestart.conf 2024-12-04 14:57:20.894419046 +0530
36+@@ -122,6 +122,8 @@
37+ qr(^google-(shutdown|startup)-scripts\.service$) => 0,
38+ # LP: #2067800
39+ qr(^runner-provisionner\.service$) => 0,
40++ # LP: #2089155
41++ qr(^keepalived\.service$) => 0,
42+
43+ # systemd stuff
44+ # (see also Debian Bug#784238 & #784437)
45diff --git a/debian/patches/series b/debian/patches/series
46index 11eb73e..c6d7b74 100644
47--- a/debian/patches/series
48+++ b/debian/patches/series
49@@ -21,3 +21,4 @@ CVE-2024-11003.patch
50 CVE-2024-48992.patch
51 CVE-2024-48990.patch
52 CVE-2024-48991.patch
53+lp2089155/0020-ubuntu-avoid-restart-keepalived.patch

Subscribers

People subscribed via source and target branches